Skip to content

fix #191201 #194965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2023
Merged

fix #191201 #194965

merged 2 commits into from
Oct 6, 2023

Conversation

tisilent
Copy link
Contributor

@tisilent tisilent commented Oct 6, 2023

fix #191201

meganrogge
meganrogge reviewed Oct 6, 2023
View reviewed changes
meganrogge
meganrogge requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Just a suggestion

@meganrogge meganrogge added this to the October 2023 milestone Oct 6, 2023
meganrogge
meganrogge approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meganrogge meganrogge merged commit 7dc5b08 into microsoft:main Oct 6, 2023
@tisilent tisilent deleted the fix-#191201 branch October 7, 2023 09:43
Alex0007 pushed a commit to Alex0007/vscode that referenced this pull request Oct 26, 2023
@meganrogge @Alex0007
Merge pull request microsoft#194965 from tisilent/fix-#191201
86df08c 
fix microsoft#191201
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

@meganrogge meganrogge meganrogge approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
October 2023
Development

Successfully merging this pull request may close these issues.

VSCode open a terminal in Terminal Panel before opening a terminal in a tab in the editor window
3 participants
@tisilent @rzhao271 @meganrogge