Skip to content

Display terminal icon correctly in panel titlebar (fix #183679) #183680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

Display terminal icon correctly in panel titlebar (fix #183679) #183680

merged 1 commit into from
Jun 7, 2023

Conversation

gjsjohnmurray
Copy link
Contributor

This PR fixes #183679

@mjbvz mjbvz assigned meganrogge and unassigned mjbvz May 28, 2023
@meganrogge meganrogge added this to the June 2023 milestone May 30, 2023
meganrogge
meganrogge approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@meganrogge meganrogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meganrogge meganrogge enabled auto-merge June 7, 2023 20:34
@meganrogge meganrogge merged commit 527dea4 into microsoft:main Jun 7, 2023
@gjsjohnmurray gjsjohnmurray deleted the fix-183679 branch June 7, 2023 21:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lramos15 lramos15 lramos15 approved these changes

@meganrogge meganrogge meganrogge approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
June 2023
Development

Successfully merging this pull request may close these issues.

Contributed terminal profile with iconPath uri in options displays $([object Object]) in panel header
5 participants
@gjsjohnmurray @lramos15 @meganrogge @mjbvz @vscodenpa