Skip to content

feat: improve package management #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Apr 9, 2025

⚠️ BREAKING CHANGE: This PR has an API change that replaces install and uninstall methods on package manager with manage.

Reasoning: Both the install and uninstall flows did very similar things. In all the implementations this was duplicating the steps. The idea here is to make it easier from the flow perspective.

image

Closes #267

@karthiknadig karthiknadig self-assigned this Apr 9, 2025
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Apr 9, 2025
@karthiknadig karthiknadig marked this pull request as ready for review April 9, 2025 20:03
@karthiknadig karthiknadig enabled auto-merge (squash) April 9, 2025 20:03
Copy link

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 9, 2025
@karthiknadig karthiknadig added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Apr 10, 2025
@karthiknadig karthiknadig merged commit cb4d48e into microsoft:main Apr 10, 2025
6 checks passed
@karthiknadig karthiknadig deleted the package-management branch April 10, 2025 17:09
karthiknadig pushed a commit that referenced this pull request Apr 11, 2025
)

The description seems to be a leftover from #279.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify package management options
2 participants