Skip to content

Update prefers-contrast example #5445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2021
Merged

Update prefers-contrast example #5445

merged 1 commit into from
May 29, 2021

Conversation

stilist
Copy link
Contributor

@stilist stilist commented May 28, 2021

What was wrong/why is this fix needed? (quick summary only)

In w3c/csswg-drafts#2943 and associated discussion, prefers-contrast’s high value was replaced with more.

MDN URL of the main page changed

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-contrast

Anything else that could help us review it

In Safari 14.1.1 on macOS 11.4, after enabling System Preferences → Accessibility → Display → Increase contrast,

using prefers-contrast: high (incorrect)
image

using prefers-contrast: more (correct)
image

In w3c/csswg-drafts#2943 and associated discussion, `prefers-contrast`'s `high` value was replaced with `more`. This PR updates the example code to match.
@stilist stilist requested a review from a team as a code owner May 28, 2021 19:18
@stilist stilist requested review from ericwbailey and removed request for a team May 28, 2021 19:18
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/CSS/@media/prefers-contrast
Title: prefers-contrast
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 42ab968 into mdn:main May 29, 2021
@sideshowbarker
Copy link
Member

Jordan, thanks much, and congrats on landing your first docs patch here — welcome aboard 🎉

@stilist stilist deleted the patch-1 branch May 30, 2021 01:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants