Revert "chore(iop): Add redirects for :open and :closed to :popover-open" #37463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyclouds2001
requested review from
chrisdavidmills
and removed request for
a team
chrisdavidmills
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redirects of
:openand:closedto:popover-openThis reverts #30342
Per bcd (https://github.com/mdn/browser-compat-data/blob/main/css/selectors/open.json and https://github.com/mdn/browser-compat-data/blob/main/css/selectors/closed.json), these are shipped in chrome once but removed later
And per spec (https://drafts.csswg.org/selectors/#selectordef-open and https://html.spec.whatwg.org/multipage/semantics-other.html#selector-open), there's seems to be a new
:openpseudo class, which is different from the previously one. And per the note, a new:closedpseudo class may also be added in the future. SO it is better to remove these redirects for now.w3c/csswg-drafts#7319 proposal for adding
:openw3c/csswg-drafts#11039 a open discussion for whether keeping
:openand:closedQw3c/csswg-drafts#11326 removes
:closed(and add note indicate this may add back in the future)