[Bug] Null safe bug fix #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nic0lette
reviewed
May 28, 2020
| val display = windowManager.defaultDisplay | ||
| display.getMetrics(displayMetrics) | ||
| val display = windowManager?.defaultDisplay | ||
| display?.getMetrics(displayMetrics) |
There was a problem hiding this comment.
If these are null, then it probably returns a height of 0, which seems like it would cause problems elsewhere which may be much more difficult to track down.
Would it make sense to explicitly throw in these situations? That is, something like:
val windowManager = context.getSystemService(WindowManager::class.java)
?: throw IllegalStateException("Could not get WindowManager")
(I realized after that there's a Kotlin extension method that works on all versions of Android for this, so it's not necessary to directly use ContextCompat)
added 2 commits
May 28, 2020 11:08
nic0lette
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.