Skip to content

[Infra] Map logs to test runs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 18, 2020
Merged

[Infra] Map logs to test runs #17

merged 8 commits into from
May 18, 2020

Conversation

Leo-Neat
Copy link

This associates specific logs with tests. This makes it clear which test run produced what output. Prior to this all logs were stored as one continuous stream.

@Leo-Neat
Copy link
Author

@nic0lette Can you have a look at this when you have some time? Thanks!

Copy link
Member

@nic0lette nic0lette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- if you wouldn't mind not using the * imports, that would be great. (If you want to go above and beyond in a follow-up, converting from using Kotlin synthetics to view binding would be the best way to go, but no pressure :)


import java.text.DateFormat
import java.util.Date
import kotlinx.android.synthetic.main.activity_media_app_testing.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please don't use '*' imports :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@Leo-Neat Leo-Neat merged commit 38fbb08 into googlesamples:master May 18, 2020
@Leo-Neat Leo-Neat deleted the logging branch May 18, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants