Merge pull request #25 from Leo-Neat/master

Leo Neat · web-flow · commit ab798e550cb6 · 2020-06-02T15:32:24.000-07:00
Extract string to XML
diff --git a/mediacontroller/src/main/java/com/example/android/mediacontroller/MediaAppTestingActivity.kt b/mediacontroller/src/main/java/com/example/android/mediacontroller/MediaAppTestingActivity.kt
@@ -472,7 +472,7 @@ class MediaAppTestingActivity : AppCompatActivity() {
                         // Init dialog
                         requestWindowFeature(Window.FEATURE_NO_TITLE)
                         setContentView(R.layout.test_suite_configure_dialog)
-                        title.text = "${testSuite.testSuiteName} Configuration"
+                        title.text = getString(R.string.configure_dialog_title, testSuite.testSuiteName)
                         subtitle.text = testSuite.testSuiteDescription
                         test_to_configure_list.layoutManager = LinearLayoutManager(this@MediaAppTestingActivity)
                         test_to_configure_list.layoutParams.height = getScreenHeightPx(this@MediaAppTestingActivity) / 2
diff --git a/mediacontroller/src/main/res/values/testing_strings.xml b/mediacontroller/src/main/res/values/testing_strings.xml
@@ -63,6 +63,7 @@
     <string name="failing_logs_header">Failing Logs:</string>
     <string name="passing_logs_header">Passing Logs:</string>
     <string name="test_iter_divider">--- Iteration ---</string>
+    <string name="configure_dialog_title">%1$s Configuration</string>
 
 
     <!-- Logs Toggle -->

-Original file line number
+Diff line change
     <string name="failing_logs_header">Failing Logs:string>
     <string name="passing_logs_header">Passing Logs:string>
     <string name="test_iter_divider">--- Iteration ---string>
 +    <string name="configure_dialog_title">%1$s Configurationstring>