Skip to content

Commit 71d20ee

Browse files
committed
Minor update.
- Update support library/gradle versions. - Fix ellipses in strings file. - Move "start session" from button to app bar icon. Change-Id: I1fd036d20d67c2cfaa1b8b3bc9143e0096847a9f
1 parent 8b46132 commit 71d20ee

File tree

9 files changed

+89
-32
lines changed

9 files changed

+89
-32
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ buildscript {
2323
google()
2424
}
2525
dependencies {
26-
classpath 'com.android.tools.build:gradle:3.0.1'
26+
classpath 'com.android.tools.build:gradle:3.1.0'
2727

2828
// NOTE: Do not place your application dependencies here; they belong
2929
// in the individual module build.gradle files
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Fri Dec 01 10:33:41 PST 2017
1+
#Fri Apr 13 10:26:08 KST 2018
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip

mediacontroller/build.gradle

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ apply plugin: 'com.android.application'
1818

1919
android {
2020
compileSdkVersion 27
21-
buildToolsVersion "27.0.1"
21+
buildToolsVersion '27.0.3'
2222

2323
compileOptions {
2424
sourceCompatibility JavaVersion.VERSION_1_8
@@ -45,15 +45,8 @@ android {
4545
}
4646

4747
dependencies {
48-
compile fileTree(dir: 'libs', include: ['*.jar'])
49-
androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', {
50-
exclude group: 'com.android.support', module: 'support-annotations'
51-
})
48+
implementation 'com.android.support:appcompat-v7:27.1.1'
49+
implementation 'com.android.support:design:27.1.1'
5250

53-
compile 'com.android.support:appcompat-v7:27.0.2'
54-
compile 'com.android.support:design:27.0.2'
55-
56-
compile 'com.android.support.constraint:constraint-layout:1.0.2'
57-
58-
testCompile 'junit:junit:4.12'
51+
implementation 'com.android.support.constraint:constraint-layout:1.0.2'
5952
}

mediacontroller/src/main/java/com/example/android/mediacontroller/MediaAppControllerActivity.java

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@
5454
import android.util.Log;
5555
import android.util.SparseArray;
5656
import android.view.LayoutInflater;
57+
import android.view.Menu;
58+
import android.view.MenuItem;
5759
import android.view.View;
5860
import android.view.ViewGroup;
5961
import android.widget.AdapterView;
@@ -360,6 +362,25 @@ protected void onRestoreInstanceState(Bundle savedInstanceState) {
360362
mUriInput.setText(savedInstanceState.getString(STATE_URI_KEY));
361363
}
362364

365+
@Override
366+
public boolean onCreateOptionsMenu(Menu menu) {
367+
getMenuInflater().inflate(R.menu.controller, menu);
368+
return true;
369+
}
370+
371+
@Override
372+
public boolean onOptionsItemSelected(MenuItem item) {
373+
if (item != null && item.getItemId() == R.id.start_session) {
374+
if (mController != null) {
375+
startSessionActivity(mController);
376+
} else {
377+
Toast.makeText(this, R.string.no_session, Toast.LENGTH_SHORT).show();
378+
}
379+
return true;
380+
}
381+
return false;
382+
}
383+
363384
private void setupToolbar(String name, Bitmap icon) {
364385
final ActionBar actionBar = getSupportActionBar();
365386
if (actionBar != null) {
@@ -430,14 +451,6 @@ private void setupButtons() {
430451
findViewById(R.id.action_prepare).setOnClickListener(preparePlayHandler);
431452
findViewById(R.id.action_play).setOnClickListener(preparePlayHandler);
432453

433-
findViewById(R.id.start_session_activity_button).setOnClickListener(v -> {
434-
if (mController != null) {
435-
startSessionActivity(mController);
436-
} else {
437-
Log.w(TAG, "Media session does not contain an Activity to start");
438-
}
439-
});
440-
441454
mAudioFocusHelper = new AudioFocusHelper(this,
442455
findViewById(R.id.audio_focus_button),
443456
findViewById(R.id.audio_focus_type));
@@ -620,11 +633,10 @@ private void startSessionActivity(MediaControllerCompat mediaController) {
620633
intent.send();
621634
return;
622635
} catch (PendingIntent.CanceledException e) {
623-
e.printStackTrace();
624-
Log.e(TAG, e.toString());
636+
Log.e(TAG, "Failed to start session activity", e);
625637
}
626638
}
627-
Log.w(TAG, "Failed to open app by session activity.");
639+
Toast.makeText(this, R.string.session_start_failed, Toast.LENGTH_SHORT).show();
628640
}
629641

630642
private class PreparePlayHandler implements View.OnClickListener {
Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,25 @@
1+
16+
17+
<vector xmlns:android="http://schemas.android.com/apk/res/android"
18+
android:width="24dp"
19+
android:height="24dp"
20+
android:viewportWidth="24.0"
21+
android:viewportHeight="24.0">
22+
<path
23+
android:fillColor="#FF000000"
24+
android:pathData="M19,19H5V5h7V3H5c-1.11,0 -2,0.9 -2,2v14c0,1.1 0.89,2 2,2h14c1.1,0 2,-0.9 2,-2v-7h-2v7zM14,3v2h3.59l-9.83,9.83 1.41,1.41L19,6.41V10h2V3h-7z"/>
25+
vector>

mediacontroller/src/main/res/layout/media_info.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,6 @@
8686
android:gravity="top|start"
8787
android:text="@string/media_info_default" />
8888

89-
<Button
90-
android:id="@+id/start_session_activity_button"
91-
android:layout_width="wrap_content"
92-
android:layout_height="wrap_content"
93-
android:text="@string/start_session_activity" />
94-
9589
<TextView
9690
style="@style/TextAppearance.AppCompat.Large"
9791
android:layout_width="wrap_content"
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
xml version="1.0" encoding="utf-8"?>
2+
17+
18+
<menu xmlns:android="http://schemas.android.com/apk/res/android"
19+
xmlns:app="http://schemas.android.com/apk/res-auto">
20+
21+
<item
22+
android:id="@+id/start_session"
23+
android:icon="@drawable/ic_launch_black_24dp"
24+
android:title="@string/start_session_activity"
25+
app:iconTint="@color/appBarIconTint"
26+
app:showAsAction="always"/>
27+
28+
menu>

mediacontroller/src/main/res/values/colors.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
<color name="colorAccent">#ff4081color>
2222
<color name="colorInactive">#a0a0a0color>
2323

24+
<color name="appBarIconTint">#fffcolor>
25+
2426
<color name="background_grey">#e0e0e0color>
2527
<color name="background_white">#f0f0f0color>
2628

mediacontroller/src/main/res/values/strings.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,16 @@
8888
<string name="audio_focus_title">Audio Focusstring>
8989
<string name="audio_focus_gain_focus">Gainstring>
9090
<string name="audio_focus_abandon_focus">Abandonstring>
91+
9192
<string name="start_session_activity">Start Session Activitystring>
93+
<string name="no_session">Media session does not contain an Activity to startstring>
94+
<string name="session_start_failed">Failed to open app by session activitystring>
9295

9396
<string name="media_browse_tree_top">Topstring>
9497
<string name="media_browse_tree_up">Upstring>
9598
<string name="media_browse_tree_header">App-provided MediaItemsstring>
9699
<string name="media_no_browser">No Browserstring>
97-
<string name="media_browse_tree_loading">Loading...string>
100+
<string name="media_browse_tree_loading">Loadingstring>
98101
<string name="media_browse_tree_empty">Empty.string>
99102
<string name="search_media">Searchstring>
100103

0 commit comments

Comments
 (0)