Skip to content

pass user.language=en to jarsigner command argument #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

ququ9
Copy link
Contributor

@ququ9 ququ9 commented Feb 4, 2021

Issue Description

The "Build Android App Bundle" works fine until just before the signing phase, but the signing process never ends.

Reason

In my understanding, The Jarsigner class is supposed to invoke the jarsigner command and monitor the keyword "Enter Passphrase for keystore:" and then pass the keystore password.

However, in an environment other than English, for example, in a Japanese environment, the keyword output by the jarsiginer command is a different from above, so the Jarsigner class cannot detect it and cannot pass the password.

for example, in english environment

$jarsigner -keystore {keystore} {app_bundle_path} {alias}
Enter Passphrase for keystore:

in japanese environment

$jarsigner -keystore {keystore} {app_bundle_path} {alias}
キーストアのパスワードを入力してください:

Fix

Change the output to be in English by passing the "-Duser.language=en" option to jarsigner.

in japanese environment with the option

$jarsigner -J-Duser.language=en -keystore {keystore} {app_bundle_path} {alias}
Enter Passphrase for keystore:

@google-cla google-cla bot added the cla: yes label Feb 4, 2021
@thanwah thanwah self-assigned this Feb 5, 2021
@thanwah
Copy link
Contributor

thanwah commented Feb 5, 2021

Thank you for creating this PR. I haven't been able to reproduce this issue myself (e.g. by switching to another language), but I also don't find that this causes any problems. So under the presumption that it fixes your issue, I'm working now on getting this merged (I have to merge it with my internal code repository before it will show up here).

@thanwah thanwah merged commit e983234 into google:master Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants