Skip to content

Commit 866efae

Browse files
Google Play Teamthanwah
Google Play Team
authored andcommitted
Fix some build warnings
Mostly these were about removing unused fields. PiperOrigin-RevId: 362547797
1 parent c57876a commit 866efae

File tree

6 files changed

+6
-5
lines changed

6 files changed

+6
-5
lines changed

GooglePlayPlugins/com.google.android.appbundle/Editor/Scripts/Internal/BuildTools/ApkSigner.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,13 @@ public class ApkSigner : IBuildTool
4141
private readonly AndroidBuildTools _androidBuildTools;
4242
private readonly JavaUtils _javaUtils;
4343

44+
#if !UNITY_2018_1_OR_NEWER
4445
private string _apkSignerJarPath;
4546
private string _keystoreName;
4647
private string _keystorePass;
4748
private string _keyaliasName;
4849
private string _keyaliasPass;
50+
#endif
4951

5052
///
5153
/// Constructor.

GooglePlayPlugins/com.google.play.assetdelivery/Runtime/Scripts/Internal/PlayAssetBundleRequestImpl.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ internal class PlayAssetBundleRequestImpl : PlayAssetBundleRequest
2525
private readonly AssetDeliveryUpdateHandler _updateHandler;
2626
private AssetDeliveryStatus _loadingStatus;
2727
private AssetDeliveryErrorCode _loadingError;
28-
private float _downloadProgress;
2928

3029
public PlayAssetBundleRequestImpl(PlayAssetPackRequestImpl packRequest,
3130
AssetDeliveryUpdateHandler updateHandler)

GooglePlayPlugins/com.google.play.assetdelivery/Runtime/Scripts/Internal/PlayAssetDeliveryInternal.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ internal class PlayAssetDeliveryInternal
3434
private const string AssetPackFolderName = "assetpack";
3535

3636
private readonly AssetPackManager _assetPackManager;
37-
private readonly AssetPackStateUpdateListener _stateUpdateListener;
3837
private readonly AssetDeliveryUpdateHandler _updateHandler;
3938

4039
private readonly PlayRequestRepository _requestRepository = new PlayRequestRepository();

GooglePlayPlugins/com.google.play.assetdelivery/Samples/AssetDeliveryDemo/Scripts/AssetPackDownloader.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ public class AssetPackDownloader : MonoBehaviour
4545

4646
private AssetBundle _assetBundle;
4747
private PlayAssetPackRequest _request;
48-
private List<Button> _buttons;
4948
private bool _requestInProgress;
5049

5150
public bool IsInitialized { get; private set; }

GooglePlayPlugins/com.google.play.common/Runtime/Scripts/LoadingScreen/ScrollingFillAnimator.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public class ScrollingFillAnimator : MonoBehaviour
3232
public float ScrollSpeed = 2.5f;
3333

3434
private RawImage _image;
35-
private Vector2 _textureOffset;
3635
private RectTransform _rectTransform;
3736

3837
private void Update()

GooglePlayPlugins/com.google.play.review/Runtime/Scripts/ReviewManager.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,10 @@ public class ReviewManager
2828
/// href="https://developer.android.com/reference/com/google/android/play/core/review/model/ReviewErrorCode">
2929
///
3030
private const int JavaReviewErrorCodePlayNotFound = -1;
31+
32+
#if !UNITY_EDITOR
3133
private readonly ReviewPlayCoreTaskManager _reviewPlayCoreTaskManager;
34+
#endif
3235

3336
public ReviewManager()
3437
{
@@ -112,4 +115,4 @@ private PlayAsyncOperation LaunchReviewFlowInternal
112115
}
113116
#endif
114117
}
115-
}
118+
}

0 commit comments

Comments
 (0)