Remove the ignorePrivateAndStaticInjectionForComponent compiler option.

This option was only used by the TCK tests, so I've replaced the compiler option with a hard-coded check for the TCK package. As was stated in the javadoc for the flag, it was not meant to be used for other purposes, so removing it should be fine.

This change also fixes a some memory bugs in how `InjectValidator` was previously implemented.

  1. Now, only a single validator instance is used in the common case where
     `privateMemberDiagnostic`/`staticMemberDiagnostic` have the default
     value (`ERROR`). Previously, this resulted in at least 3 instances being
     used, which duplicated caching across all three instances
  2. Now, both `validator` and `validatorWhenGeneratingCode` have their caches
     cleared between rounds. Previously, only `validator` had its cache cleared
     because `validatorWhenGeneratingCode` was being created and managed
     outside Dagger. This also created a memory leak in one case because it was
     used within a scoped binding and it's cache was never cleared.

RELNOTES=Remove the `ignorePrivateAndStaticInjectionForComponent` compiler option.
PiperOrigin-RevId: 686174065

Author: bcorso

java/dagger/internal/codegen/bindinggraphvalidation/InjectBindingValidator.java

@@ -33,7 +33,7 @@ final class InjectBindingValidator extends ValidationBindingGraphPlugin {
 
   @Inject
   InjectBindingValidator(InjectValidator injectValidator) {
-    this.injectValidator = injectValidator.whenGeneratingCode();
+    this.injectValidator = injectValidator;
   }
 
   @Override
@@ -50,7 +50,8 @@ public void visitGraph(BindingGraph bindingGraph, DiagnosticReporter diagnosticR
 
   private void validateInjectionBinding(Binding node, DiagnosticReporter diagnosticReporter) {
     ValidationReport typeReport =
-        injectValidator.validate(node.key().type().xprocessing().getTypeElement());
+        injectValidator.validateWhenGeneratingCode(
+            node.key().type().xprocessing().getTypeElement());
     for (Item item : typeReport.allItems()) {
       diagnosticReporter.reportBinding(item.kind(), node, item.message());
     }

java/dagger/internal/codegen/compileroption/CompilerOptions.java

@@ -54,15 +54,6 @@ public final boolean doCheckForNulls() {
    */
   public abstract boolean includeStacktraceWithDeferredErrorMessages();
 
-  /**
-   * If {@code true}, Dagger will generate factories and components even if some members-injected
-   * types have {@code private} or {@code static} {@code @Inject}-annotated members.
-   *
-   * This should only ever be enabled by the TCK tests. Disabling this validation could lead to
-   * generating code that does not compile.
-   */
-  public abstract boolean ignorePrivateAndStaticInjectionForComponent();
-
   public abstract ValidationType scopeCycleValidationType();
 
   /**

java/dagger/internal/codegen/compileroption/ProcessingEnvironmentCompilerOptions.java

@@ -29,7 +29,6 @@
 import static dagger.internal.codegen.compileroption.ProcessingEnvironmentCompilerOptions.Feature.FLOATING_BINDS_METHODS;
 import static dagger.internal.codegen.compileroption.ProcessingEnvironmentCompilerOptions.Feature.FORMAT_GENERATED_SOURCE;
 import static dagger.internal.codegen.compileroption.ProcessingEnvironmentCompilerOptions.Feature.GENERATED_CLASS_EXTENDS_COMPONENT;
-import static dagger.internal.codegen.compileroption.ProcessingEnvironmentCompilerOptions.Feature.IGNORE_PRIVATE_AND_STATIC_INJECTION_FOR_COMPONENT;
 import static dagger.internal.codegen.compileroption.ProcessingEnvironmentCompilerOptions.Feature.IGNORE_PROVISION_KEY_WILDCARDS;
 import static dagger.internal.codegen.compileroption.ProcessingEnvironmentCompilerOptions.Feature.INCLUDE_STACKTRACE_WITH_DEFERRED_ERROR_MESSAGES;
 import static dagger.internal.codegen.compileroption.ProcessingEnvironmentCompilerOptions.Feature.PLUGINS_VISIT_FULL_BINDING_GRAPHS;
@@ -139,11 +138,6 @@ public boolean includeStacktraceWithDeferredErrorMessages() {
     return isEnabled(INCLUDE_STACKTRACE_WITH_DEFERRED_ERROR_MESSAGES);
   }
 
-  @Override
-  public boolean ignorePrivateAndStaticInjectionForComponent() {
-    return isEnabled(IGNORE_PRIVATE_AND_STATIC_INJECTION_FOR_COMPONENT);
-  }
-
   @Override
   public ValidationType scopeCycleValidationType() {
     return parseOption(DISABLE_INTER_COMPONENT_SCOPE_VALIDATION);
@@ -325,8 +319,6 @@ enum Feature implements EnumOption {
 
     INCLUDE_STACKTRACE_WITH_DEFERRED_ERROR_MESSAGES,
 
-    IGNORE_PRIVATE_AND_STATIC_INJECTION_FOR_COMPONENT,
-
     EXPERIMENTAL_AHEAD_OF_TIME_SUBCOMPONENTS,
 
     FORCE_USE_SERIALIZED_COMPONENT_IMPLEMENTATIONS,

java/dagger/internal/codegen/javac/JavacPluginCompilerOptions.java

@@ -66,11 +66,6 @@ public boolean includeStacktraceWithDeferredErrorMessages() {
     return false;
   }
 
-  @Override
-  public boolean ignorePrivateAndStaticInjectionForComponent() {
-    return false;
-  }
-
   @Override
   public ValidationType scopeCycleValidationType() {
     return NONE;

java/dagger/internal/codegen/validation/InjectBindingRegistryImpl.java

@@ -84,7 +84,6 @@ final class InjectBindingRegistryImpl implements InjectBindingRegistry {
   private final XProcessingEnv processingEnv;
   private final XMessager messager;
   private final InjectValidator injectValidator;
-  private final InjectValidator injectValidatorWhenGeneratingCode;
   private final KeyFactory keyFactory;
   private final BindingFactory bindingFactory;
   private final CompilerOptions compilerOptions;
@@ -106,7 +105,7 @@ void generateBindings(SourceFileGenerator generator) throws SourceFileGenerat
         checkState(!binding.unresolved().isPresent());
         XType type = binding.key().type().xprocessing();
         if (!isDeclared(type)
-            || injectValidatorWhenGeneratingCode.validate(type.getTypeElement()).isClean()) {
+                || injectValidator.validateWhenGeneratingCode(type.getTypeElement()).isClean()) {
           generator.generate(binding);
         }
         materializedBindingKeys.add(binding.key());
@@ -223,7 +222,6 @@ private void tryToCacheBinding(B binding) {
     this.processingEnv = processingEnv;
     this.messager = messager;
     this.injectValidator = injectValidator;
-    this.injectValidatorWhenGeneratingCode = injectValidator.whenGeneratingCode();
     this.keyFactory = keyFactory;
     this.bindingFactory = bindingFactory;
     this.compilerOptions = compilerOptions;