Skip to content

Commit 91450da

Browse files
ansmanDagger Team
authored and
Dagger Team
committed
Fix the isolated project violation
`dependency.group` would be accessed which, for project dependencies, would cause an isolated project violation. Now project dependencies are filtered out. This partially fixes #4423 Closes #4570 RELNOTES=Fix project isolation violation when checking that Hilt libraries are applied along the Gradle plugin. PiperOrigin-RevId: 714428280
1 parent 347cfe1 commit 91450da

File tree

1 file changed

+4
-1
lines changed
  • java/dagger/hilt/android/plugin/main/src/main/kotlin/dagger/hilt/android/plugin

1 file changed

+4
-1
lines changed

java/dagger/hilt/android/plugin/main/src/main/kotlin/dagger/hilt/android/plugin/HiltGradlePlugin.kt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ import org.gradle.api.Plugin
5151
import org.gradle.api.Project
5252
import org.gradle.api.Task
5353
import org.gradle.api.artifacts.Configuration
54+
import org.gradle.api.artifacts.ExternalDependency
5455
import org.gradle.api.artifacts.component.ProjectComponentIdentifier
5556
import org.gradle.api.attributes.Attribute
5657
import org.gradle.api.provider.ProviderFactory
@@ -421,7 +422,9 @@ class HiltGradlePlugin @Inject constructor(private val providers: ProviderFactor
421422
it.name.startsWith("hiltAnnotationProcessor") || it.name.startsWith("hiltCompileOnly")
422423
}
423424
.flatMap { configuration ->
424-
configuration.dependencies.map { dependency -> dependency.group to dependency.name }
425+
configuration.dependencies.filterIsInstance<ExternalDependency>().map { dependency ->
426+
dependency.group to dependency.name
427+
}
425428
}
426429
.toSet()
427430
fun getMissingDepMsg(depCoordinate: String): String =

0 commit comments

Comments
 (0)