feat: Add support for new Firestore types #6928

ehsannas · 2025-05-01T23:53:09Z

Adds support for MinKey, MaxKey, RegexValue, Int32Value, BsonObjectId, BsonTimestamp, and BsonBinaryData.

ehsannas · 2025-05-01T23:53:44Z

TODO:

Fix merge conflicts
Add changelog
Fix TODOs in the code

github-actions · 2025-05-02T21:04:34Z

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v11.1

github-actions · 2025-05-02T21:10:30Z

Test Results

188 files + 166 188 suites +166 4m 33s ⏱️ + 3m 59s
1 296 tests +1 196 1 280 ✅ +1 180 16 💤 +16 0 ❌ ±0
2 616 runs +2 416 2 584 ✅ +2 384 32 💤 +32 0 ❌ ±0

Results for commit 4417c2b. ± Comparison against base commit 0a880cc.

This pull request removes 100 and adds 1296 tests. Note that renamed tests count towards both.

com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ citation parsed correctly
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ image rejected
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ long reply
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ prompt blocked for safety
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ short reply
com.google.firebase.ai.DevAPIStreamingSnapshotTests ‑ stopped for recitation
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ citation returns correctly
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ invalid api key
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ long reply
com.google.firebase.ai.DevAPIUnarySnapshotTests ‑ response blocked for safety
…

com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.BsonTypesTest ‑ testBsonBinaryDataEquality
com.google.firebase.firestore.BsonTypesTest ‑ testBsonObjectIdEquality
com.google.firebase.firestore.BsonTypesTest ‑ testBsonTimeStampEquality
com.google.firebase.firestore.BsonTypesTest ‑ testInt32Equality
com.google.firebase.firestore.BsonTypesTest ‑ testMaxKeyIsSingleton
…

♻️ This comment has been updated with latest results.

google-oss-bot · 2025-05-02T21:10:48Z

Coverage Report ¹

Affected Products

`firebase-firestore`

Overall coverage changed from 45.77% (0a880cc) to 46.61% (c17a8ad) by +0.84%.

18 individual files with coverage change

Filename	Base (`0a880cc`)	Merge (`c17a8ad`)	Diff
BsonBinaryData.java	?	78.95%	?
BsonObjectId.java	?	81.82%	?
BsonTimestamp.java	?	60.00%	?
CustomClassMapper.java	83.74%	79.19%	-4.54%
DocumentSnapshot.java	52.58%	49.04%	-3.54%
FirestoreIndexValueWriter.java	82.11%	98.72%	+16.61%
IndexByteEncoder.java	88.57%	94.29%	+5.71%
Int32Value.java	?	81.82%	?
LruGarbageCollector.java	97.27%	93.64%	-3.64%
MaxKey.java	?	100.00%	?
MinKey.java	?	100.00%	?
OrderedCodeWriter.java	68.52%	72.84%	+4.32%
RegexValue.java	?	83.33%	?
SetMutation.java	94.44%	97.22%	+2.78%
UserDataReader.java	71.30%	77.21%	+5.91%
UserDataWriter.java	44.64%	60.76%	+16.12%
Value.java	41.48%	42.49%	+1.02%
Values.java	96.52%	98.01%	+1.49%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/dMQWHQ0sCC.html

github-actions · 2025-05-02T21:12:27Z

+ + + + + + + + + + + + + + + + + + + + + + + + + + + +

Javadoc Changes:

--- /home/runner/diff/original/firebase-kotlindoc/android/client/firebase-firestore/_toc.yaml	2025-05-05 16:48:46.839222296 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/client/firebase-firestore/_toc.yaml	2025-05-05 16:45:13.607330716 +0000
@@ -38,6 +38,12 @@
       path: "/docs/reference/android/com/google/firebase/firestore/AggregateQuerySnapshot.html"
     - title: "Blob"
       path: "/docs/reference/android/com/google/firebase/firestore/Blob.html"
+    - title: "BsonBinaryData"
+      path: "/docs/reference/android/com/google/firebase/firestore/BsonBinaryData.html"
+    - title: "BsonObjectId"
+      path: "/docs/reference/android/com/google/firebase/firestore/BsonObjectId.html"
+    - title: "BsonTimestamp"
+      path: "/docs/reference/android/com/google/firebase/firestore/BsonTimestamp.html"
     - title: "CollectionReference"
       path: "/docs/reference/android/com/google/firebase/firestore/CollectionReference.html"
     - title: "DocumentChange"
@@ -62,10 +68,14 @@
       path: "/docs/reference/android/com/google/firebase/firestore/FirestoreKt.html"
     - title: "GeoPoint"
       path: "/docs/reference/android/com/google/firebase/firestore/GeoPoint.html"
+    - title: "Int32Value"
+      path: "/docs/reference/android/com/google/firebase/firestore/Int32Value.html"
     - title: "LoadBundleTask"
       path: "/docs/reference/android/com/google/firebase/firestore/LoadBundleTask.html"
     - title: "LoadBundleTaskProgress"
       path: "/docs/reference/android/com/google/firebase/firestore/LoadBundleTaskProgress.html"
+    - title: "MaxKey"
+      path: "/docs/reference/android/com/google/firebase/firestore/MaxKey.html"
     - title: "MemoryCacheSettings"
       path: "/docs/reference/android/com/google/firebase/firestore/MemoryCacheSettings.html"
     - title: "MemoryCacheSettings.Builder"
@@ -78,6 +88,8 @@
       path: "/docs/reference/android/com/google/firebase/firestore/MemoryLruGcSettings.html"
     - title: "MemoryLruGcSettings.Builder"
       path: "/docs/reference/android/com/google/firebase/firestore/MemoryLruGcSettings.Builder.html"
+    - title: "MinKey"
+      path: "/docs/reference/android/com/google/firebase/firestore/MinKey.html"
     - title: "PersistentCacheIndexManager"
       path: "/docs/reference/android/com/google/firebase/firestore/PersistentCacheIndexManager.html"
     - title: "PersistentCacheSettings"
@@ -90,6 +102,8 @@
       path: "/docs/reference/android/com/google/firebase/firestore/QueryDocumentSnapshot.html"
     - title: "QuerySnapshot"
       path: "/docs/reference/android/com/google/firebase/firestore/QuerySnapshot.html"
+    - title: "RegexValue"
+      path: "/docs/reference/android/com/google/firebase/firestore/RegexValue.html"
     - title: "SetOptions"
       path: "/docs/reference/android/com/google/firebase/firestore/SetOptions.html"
     - title: "SnapshotListenOptions"

--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/BsonBinaryData.html	1970-01-01 00:00:00.000000000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/BsonBinaryData.html	2025-05-05 16:45:13.629330705 +0000
@@ -0,0 +1,329 @@
+
+  
+    BsonBinaryData
+{% setvar book_path %}/_book.yaml{% endsetvar %}
+{% include "docs/reference/android/_reference-head-tags.html" %}
+  
+  
+    
+    BsonBinaryData
+    
+      
public final class BsonBinaryData
+    
+    
+    Represents a BSON Binary data type in Firestore documents.
+    Summary
+    
+      +        +          +          +        +        +          +            +          +        +        +          +            +            +          +          +            +            +          +          +            +            +          +          +            +            +          +          +            +            +          +          +            +            +          +          +            +            +          +          +            +            +          +        +      






Public methods




ByteString

+              @Nonnull
dataAsByteString()
+              Returns the underlying data as a ByteString.
+            


byte[]

+              @Nonnull
dataAsBytes()
+              Returns a copy of the underlying data as a byte[] array.
+            


boolean

+              equals(Object obj)
+              Returns true if this BsonBinaryData is equal to the provided object.
+            


static BsonBinaryData

+              @Nonnull
fromByteString(int subtype, @Nonnull ByteString byteString)
+              Creates a new BsonBinaryData instance from the provided ByteString and subtype.
+            


static BsonBinaryData

+              @Nonnull
fromBytes(int subtype, @Nonnull byte[] bytes)
+              Creates a new BsonBinaryData instance from the provided bytes and subtype.
+            


int

+              hashCode()
+            


int

+              subtype()
+              Returns the subtype of this binary data.
+            


String

+              toString()
+            



+    
+    
+      Public methods
+      
+        dataAsByteString
+        @Nonnull
public ByteString dataAsByteString()
+        Returns the underlying data as a ByteString.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Returns




ByteString

+                  The data as a ByteString.
+                



+        
+      
+      
+        dataAsBytes
+        @Nonnull
public byte[] dataAsBytes()
+        Returns a copy of the underlying data as a byte[] array.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Returns




byte[]

+                  The data as a byte[] array.
+                



+        
+      
+      
+        equals
+        public boolean equals(Object obj)
+        Returns true if this BsonBinaryData is equal to the provided object.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Parameters




Object obj

+                  The object to compare against.
+                



+        
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Returns




boolean

+                  Whether this BsonBinaryData is equal to the provided object.
+                



+        
+      
+      
+        fromByteString
+        @Nonnull
public static BsonBinaryData fromByteString(int subtype, @Nonnull ByteString byteString)
+        Creates a new BsonBinaryData instance from the provided ByteString and subtype.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +              +                +                +              +            +          






Parameters




int subtype

+                  The subtype to use for this instance.
+                


@Nonnull ByteString byteString

+                  The byteString to use for this instance.
+                



+        
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Returns




BsonBinaryData

+                  The new BsonBinaryData instance
+                



+        
+      
+      
+        fromBytes
+        @Nonnull
public static BsonBinaryData fromBytes(int subtype, @Nonnull byte[] bytes)
+        Creates a new BsonBinaryData instance from the provided bytes and subtype. Makes a copy of the bytes passed in.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +              +                +                +              +            +          






Parameters




int subtype

+                  The subtype to use for this instance.
+                


@Nonnull byte[] bytes

+                  The bytes to use for this instance.
+                



+        
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Returns




BsonBinaryData

+                  The new BsonBinaryData instance
+                



+        
+      
+      
+        hashCode
+        public int hashCode()
+      
+      
+        subtype
+        public int subtype()
+        Returns the subtype of this binary data.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Returns




int

+                  The subtype of the binary data.
+                



+        
+      
+      
+        toString
+        public String toString()
+      
+    
+  
+
+

--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/BsonObjectId.html	1970-01-01 00:00:00.000000000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/BsonObjectId.html	2025-05-05 16:45:13.658330691 +0000
@@ -0,0 +1,188 @@
+
+  
+    BsonObjectId
+{% setvar book_path %}/_book.yaml{% endsetvar %}
+{% include "docs/reference/android/_reference-head-tags.html" %}
+  
+  
+    
+    BsonObjectId
+    
+      
public final class BsonObjectId
+    
+    
+    Represents a BSON ObjectId type in Firestore documents.
+    Summary
+    
+      +        +          +          +        +        +          +            +          +        +        +          +            +            +          +        +      






Public fields




final String

+              value
+            



+    
+    
+      +        +          +          +        +        +          +            +          +        +        +          +            +          +        +      






Public constructors





+              BsonObjectId(@NonNull String oid)
+              Constructor that creates a new BSON ObjectId value with the given value.
+            



+    
+    
+      +        +          +          +        +        +          +            +          +        +        +          +            +            +          +          +            +            +          +          +            +            +          +        +      






Public methods




boolean

+              equals(Object obj)
+              Returns true if this BsonObjectId is equal to the provided object.
+            


int

+              hashCode()
+            


String

+              toString()
+            



+    
+    
+      Public fields
+      
+        value
+        public final String value
+      
+    
+    
+      Public constructors
+      
+        BsonObjectId
+        public BsonObjectId(@NonNull String oid)
+        Constructor that creates a new BSON ObjectId value with the given value.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Parameters




@NonNull String oid

+                  The 24-character hex string representing the ObjectId.
+                



+        
+      
+    
+    
+      Public methods
+      
+        equals
+        public boolean equals(Object obj)
+        Returns true if this BsonObjectId is equal to the provided object.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Parameters




Object obj

+                  The object to compare against.
+                



+        
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Returns




boolean

+                  Whether this BsonObjectId is equal to the provided object.
+                



+        
+      
+      
+        hashCode
+        public int hashCode()
+      
+      
+        toString
+        public String toString()
+      
+    
+  
+
+

--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/BsonTimestamp.html	1970-01-01 00:00:00.000000000 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/BsonTimestamp.html	2025-05-05 16:45:13.657330691 +0000
@@ -0,0 +1,204 @@
+
+  
+    BsonTimestamp
+{% setvar book_path %}/_book.yaml{% endsetvar %}
+{% include "docs/reference/android/_reference-head-tags.html" %}
+  
+  
+    
+    BsonTimestamp
+    
+      
public final class BsonTimestamp
+    
+    
+    Represents a BSON Timestamp type in Firestore documents.
+    Summary
+    
+      +        +          +          +        +        +          +            +          +        +        +          +            +            +          +          +            +            +          +        +      






Public fields




final long

+              increment
+            


final long

+              seconds
+            



+    
+    
+      +        +          +          +        +        +          +            +          +        +        +          +            +          +        +      






Public constructors





+              BsonTimestamp(long seconds, long increment)
+              Constructor that creates a new BSON Timestamp value with the given values.
+            



+    
+    
+      +        +          +          +        +        +          +            +          +        +        +          +            +            +          +          +            +            +          +          +            +            +          +        +      






Public methods




boolean

+              equals(Object obj)
+              Returns true if this BsonTimestampValue is equal to the provided object.
+            


int

+              hashCode()
+            


String

+              toString()
+            



+    
+    
+      Public fields
+      
+        increment
+        public final long increment
+      
+      
+        seconds
+        public final long seconds
+      
+    
+    
+      Public constructors
+      
+        BsonTimestamp
+        public BsonTimestamp(long seconds, long increment)
+        Constructor that creates a new BSON Timestamp value with the given values.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +              +                +                +              +            +          






Parameters




long seconds

+                  An unsigned 32-bit integer value stored as long representing the seconds.
+                


long increment

+                  An unsigned 32-bit integer value stored as long representing the increment.
+                



+        
+      
+    
+    
+      Public methods
+      
+        equals
+        public boolean equals(Object obj)
+        Returns true if this BsonTimestampValue is equal to the provided object.
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Parameters




Object obj

+                  The object to compare against.
+                



+        
+        
+          +            +              +              +            +            +              +                +              +            +            +              +                +                +              +            +          






Returns




boolean

+                  Whether this BsonTimestampValue is equal to the provided object.
+                



+        
+      
+      
+        hashCode
+        public int hashCode()
+      
+      
+        toString
+        public String toString()
+      
+    
+  
+
+

--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/firestore/DocumentSnapshot.html	2025-05-05 16:48:46.849222291 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/firestore/DocumentSnapshot.html	2025-05-05 16:45:13.625330707 +0000
@@ -188,6 +188,27 @@

@Nullable BsonBinaryData

+

getBsonBinaryData(@NonNull String field)

+

Returns the value of the field as a BsonBinaryData.

+

@Nullable BsonObjectId

+

getBsonObjectId(@NonNull String field)

+

Returns the value of the field as a BsonObjectId.

+

@Nullable BsonTimestamp

+

getBsonTimestamp(@NonNull String field)

+

Returns the value of the field as a BsonTimestampValue.

+

@Nullable Map<String, Object>

getData()

@@ -243,6 +264,13 @@

@Nullable Int32Value

+

getInt32Value(@NonNull String field)

+

Returns the value of the field as a 32-bit integer.

+

@Nullable Long

getLong(@NonNull String field)

@@ -250,12 +278,26 @@

@Nullable MaxKey

+

getMaxKey(@NonNull String field)

+

Returns the value of the field as a MaxKey.

+

@NonNull SnapshotMetadata

getMetadata()

@Nullable MinKey

+

getMinKey(@NonNull String field)

+

Returns the value of the field as a MinKey.

+

@NonNull DocumentReference

getReference()

@@ -263,6 +305,13 @@

@Nullable RegexValue

+

getRegexValue(@NonNull String field)

+

Returns the value of the field as a RegexValue.

+

@Nullable String

getString(@NonNull String field)

@@ -1089,6 +1138,210 @@

google-oss-bot · 2025-05-02T21:20:07Z

Size Report ¹

Affected Products

firebase-firestore
Type Base (0a880cc) Merge (c17a8ad) Diff
aar 1.45 MB 1.46 MB +13.7 kB (+0.9%)
apk (release) 11.4 MB 11.4 MB +15.9 kB (+0.1%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/mXpQYw6kgI.html

google-oss-bot · 2025-05-02T21:58:27Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (0a880cc) and the CI merge commit (c17a8ad)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 0a880cc: https://storage.googleapis.com/firebase-sdk-metric-reports/wWX0ybmViC/index.html
- c17a8ad: https://storage.googleapis.com/firebase-sdk-metric-reports/Y4w4EMTI2t/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`0a880cc`	`c17a8ad`	Diff	Significant (?)
p10	263 ±11 μs	261 ±9 μs	-1.48 μs (-0.6%)	NO
p25	271 ±10 μs	269 ±12 μs	-1.56 μs (-0.6%)	NO
p50	282 ±10 μs	280 ±15 μs	-2.68 μs (-0.9%)	NO
p75	301 ±14 μs	303 ±28 μs	+2.17 μs (+0.7%)	NO
p90	343 ±53 μs	370 ±78 μs	+27.3 μs (+8.0%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`c17a8ad`	2025-05-05_16:58:38.907655_OQaI 2025-05-05_16:58:38.908952_oQjb 2025-05-05_16:58:38.908962_FVMk 2025-05-05_16:58:38.908968_ccwX 2025-05-05_16:58:38.908972_bDak 2025-05-05_16:58:38.908976_EUoc 2025-05-05_16:58:38.908984_jhNk 2025-05-05_16:58:38.908987_uYvt 2025-05-05_16:58:38.908991_DKHu 2025-05-05_16:58:38.908995_CXtI

redfin-30

Percentile	`0a880cc`	`c17a8ad`	Diff	Significant (?)
p10	526 ±43 μs	501 ±37 μs	-25.5 μs (-4.8%)	NO
p25	541 ±45 μs	516 ±40 μs	-25.2 μs (-4.7%)	NO
p50	562 ±46 μs	538 ±40 μs	-24.0 μs (-4.3%)	NO
p75	589 ±51 μs	567 ±43 μs	-21.8 μs (-3.7%)	NO
p90	628 ±75 μs	602 ±45 μs	-25.9 μs (-4.1%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`c17a8ad`	2025-05-05_16:58:38.907655_OQaI 2025-05-05_16:58:38.908952_oQjb 2025-05-05_16:58:38.908962_FVMk 2025-05-05_16:58:38.908968_ccwX 2025-05-05_16:58:38.908972_bDak 2025-05-05_16:58:38.908976_EUoc 2025-05-05_16:58:38.908984_jhNk 2025-05-05_16:58:38.908987_uYvt 2025-05-05_16:58:38.908991_DKHu 2025-05-05_16:58:38.908995_CXtI

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`0a880cc`	`c17a8ad`	Diff	Significant (?)
p10	193 ±2 ms	199 ±2 ms	+5.77 ms (+3.0%)	NO
p25	199 ±2 ms	205 ±2 ms	+5.89 ms (+3.0%)	NO
p50	205 ±2 ms	212 ±2 ms	+6.48 ms (+3.2%)	NO
p75	213 ±3 ms	220 ±3 ms	+6.83 ms (+3.2%)	NO
p90	221 ±3 ms	230 ±4 ms	+8.57 ms (+3.9%)	NO

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`c17a8ad`	2025-05-05_16:58:38.907655_OQaI 2025-05-05_16:58:38.908952_oQjb 2025-05-05_16:58:38.908962_FVMk 2025-05-05_16:58:38.908968_ccwX 2025-05-05_16:58:38.908972_bDak 2025-05-05_16:58:38.908976_EUoc 2025-05-05_16:58:38.908984_jhNk 2025-05-05_16:58:38.908987_uYvt 2025-05-05_16:58:38.908991_DKHu 2025-05-05_16:58:38.908995_CXtI

redfin-30

Percentile	`0a880cc`	`c17a8ad`	Diff	Significant (?)
p10	225 ±4 ms	247 ±11 ms	+22.0 ms (+9.8%)	NO
p25	231 ±4 ms	253 ±11 ms	+22.7 ms (+9.8%)	NO
p50	239 ±5 ms	261 ±11 ms	+22.4 ms (+9.4%)	NO
p75	247 ±5 ms	271 ±11 ms	+24.5 ms (+9.9%)	NO
p90	255 ±5 ms	286 ±11 ms	+30.8 ms (+12.1%)	MAYBE

20 test runs in comparison

Commit	Test Runs
`0a880cc`	2025-05-01_22:24:39.654561_vcIC 2025-05-01_22:24:39.654622_MJFO 2025-05-01_22:24:39.654634_QIyf 2025-05-01_22:24:39.654642_mpdI 2025-05-01_22:24:39.654649_ZYgA 2025-05-01_22:24:39.654657_jRtF 2025-05-01_22:24:39.654674_NClG 2025-05-01_22:24:39.654682_GTUC 2025-05-01_22:24:39.654688_wHwo 2025-05-01_22:24:39.654694_iiia
`c17a8ad`	2025-05-05_16:58:38.907655_OQaI 2025-05-05_16:58:38.908952_oQjb 2025-05-05_16:58:38.908962_FVMk 2025-05-05_16:58:38.908968_ccwX 2025-05-05_16:58:38.908972_bDak 2025-05-05_16:58:38.908976_EUoc 2025-05-05_16:58:38.908984_jhNk 2025-05-05_16:58:38.908987_uYvt 2025-05-05_16:58:38.908991_DKHu 2025-05-05_16:58:38.908995_CXtI

https://storage.googleapis.com/firebase-sdk-metric-reports/jpAQUEDUqK/index.html

ehsannas · 2025-05-02T21:45:45Z

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/POJOTest.java

  @Test
  public void testSetMerge() {
-    CollectionReference collection = testCollection();
+    CollectionReference collection = testCollectionOnNightly();


These should be switched back

ehsannas · 2025-05-02T21:47:17Z

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/BsonTypesTest.java

+  }
+
+  // TODO(Mila/BSON): remove the cache population after updating the
+  // assertSDKQueryResultsConsistentWithBackend


these should be resolved.

IIUC all of the

// Pre-populate the cache with all docs waitFor(randomColl.get());

can now be removed.

milaGGL added 3 commits April 8, 2025 10:40

Add new BSON types to public API (#573)

b280c08

Implement indexing for bson types (#576)

98e5e8a

Remove FieldValue constructor methods (#578)

ef4e5ea

google-oss-bot added the size/XXL label May 1, 2025

ehsannas self-assigned this May 1, 2025

ehsannas added 2 commits May 2, 2025 13:57

Merge remote-tracking branch 'origin/main' into bson

d0e219b

Fix merge conflicts.

31e3290

ehsannas added 2 commits May 2, 2025 14:20

Fix formatting.

6f7c203

Add changelog.

327f2c4

ehsannas assigned milaGGL and unassigned ehsannas May 2, 2025

ehsannas commented May 2, 2025

View reviewed changes

resolve TODOs

4417c2b

Public methods
`boolean`	+ `equals(Object obj)` + Returns true if this Int32Value is equal to the provided object. +
`int`	+ `hashCode()` +
`String`	+ `toString()` +

Public methods
`boolean`	+ `equals(Object obj)` + Returns true if this MaxKey is equal to the provided object. +
`int`	+ `hashCode()` +
`static @NonNull MaxKey`	+ `instance()` +

Public methods
`boolean`	+ `equals(Object obj)` + Returns true if this MinKey is equal to the provided object. +
`int`	+ `hashCode()` +
`static @NonNull MinKey`	+ `instance()` +

Public fields
`final String`	+ `options` +
`final String`	+ `pattern` +

Public methods
`boolean`	+ `equals(Object obj)` + Returns true if this RegexValue is equal to the provided object. +
`int`	+ `hashCode()` +
`String`	+ `toString()` +

Public functions
`ByteString!`	+ `@Nonnull dataAsByteString()` + Returns the underlying data as a ByteString. +
`ByteArray<Byte>!`	+ `@Nonnull dataAsBytes()` + Returns a copy of the underlying data as a byte[] array. +
`Boolean`	+ `equals(obj: Any!)` + Returns true if this BsonBinaryData is equal to the provided object. +
`java-static BsonBinaryData!`	+ `@Nonnull fromByteString(subtype: Int, @Nonnull byteString: ByteString!)` + Creates a new BsonBinaryData instance from the provided ByteString and subtype. +
`java-static BsonBinaryData!`	+ `@Nonnull fromBytes(subtype: Int, @Nonnull bytes: ByteArray!)` + Creates a new BsonBinaryData instance from the provided bytes and subtype. +
`Int`	+ `hashCode()` +
`Int`	+ `subtype()` + Returns the subtype of this binary data. +
`String!`	+ `toString()` +

Parameters
`subtype: Int`	+ The subtype to use for this instance. +
`@Nonnull byteString: ByteString!`	+ The byteString to use for this instance. +

Parameters
`subtype: Int`	+ The subtype to use for this instance. +
`@Nonnull bytes: ByteArray!`	+ The bytes to use for this instance. +

Parameters
`seconds: Long`	+ An unsigned 32-bit integer value stored as long representing the seconds. +
`increment: Long`	+ An unsigned 32-bit integer value stored as long representing the increment. +

feat: Add support for new Firestore types #6928

Are you sure you want to change the base?

feat: Add support for new Firestore types #6928

Uh oh!

Conversation

ehsannas commented May 1, 2025

Uh oh!

ehsannas commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 2, 2025

Vertex AI Mock Responses Check ⚠️

Uh oh!

github-actions bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

google-oss-bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

Uh oh!

github-actions bot commented May 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

BsonBinaryData

Summary

Public methods

Public methods

dataAsByteString

dataAsBytes

equals

fromByteString

fromBytes

hashCode

subtype

toString

BsonObjectId

Summary

Public fields

Public constructors

Public methods

Public fields

value

Public constructors

BsonObjectId

Public methods

equals

hashCode

toString

BsonTimestamp

Summary

Public fields

Public constructors

Public methods

Public fields

increment

seconds

Public constructors

BsonTimestamp

Public methods

equals

hashCode

toString

getBsonBinaryData

getBsonObjectId

getBsonTimestamp

getData

getInt32Value

getLong

getMaxKey

getMetadata

getMinKey

getReference

getRegexValue

Int32Value

Summary

Public fields

Public constructors

ehsannas commented May 1, 2025 •

edited

Loading

github-actions bot commented May 2, 2025 •

edited

Loading

google-oss-bot commented May 2, 2025 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

github-actions bot commented May 2, 2025 •

edited

Loading