refactor(firestore-bigquery-changetracker): improve partitioning code #2445
+2,009
−6,678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabljac
commented
Jun 12, 2025
| const IngestionTimePartitioningSchema = BaseConfigSchema.extend({ | ||
| timePartitioning: z.enum(["HOUR", "DAY", "MONTH", "YEAR"]), | ||
| timePartitioningColumn: z.undefined(), | ||
| timePartitioningFieldType: z.undefined(), |
There was a problem hiding this comment.
I think we should change this to timePartitioningColumnType to continue semantic difference between firestore and BQ
We should consistently call BQ fields/columns "columns"
and Firestore fields we will call "fields"
cabljac
commented
Jun 12, 2025
| import { z } from "zod"; | ||
|
|
||
| /** | ||
| * This is the shared base for all configuration variants. It includes all |
There was a problem hiding this comment.
This is a public schema/type for the main exported change tracker class
cabljac
commented
Jun 12, 2025
| FieldInternalSchema, | ||
| ]); | ||
|
|
||
| const InternalPartitioningSchema = z.preprocess((data) => { |
There was a problem hiding this comment.
This adds the partitioningType onto the config...
I dont know whether we actually need the rest of the config, perhaps it's better just to extract a smaller config. Need to check what we actually use here from config
cabljac
commented
Jun 12, 2025
| schema?: object | ||
| import { BigQuery, TableField } from "@google-cloud/bigquery"; | ||
|
|
||
| const BaseSchema = z.object({ |
cabljac
force-pushed
the
@invertase/fix-partitioning
branch
from
bcc3fe9 to
06ba7e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.