EIP-7951: Precompile for secp256r1 Curve Support #31991
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
requested review from
karalabe,
gballet,
rjl493456442,
zsfelfoldi and
jwasinger
as code owners
fjl
added a commit
that referenced
this pull request
Jun 9, 2025
Thegaram
reviewed
Jun 10, 2025
crypto/secp256r1/verifier.go
Outdated
Comment on lines
30
to
32
| if x.Sign() == 0 && y.Sign() == 0 { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
Is this check needed? Which part of the EIP does this correspond to?
I believe this check was not added in the RIP version, neither was it present in the implementation deployed in Scroll or OP.
There was a problem hiding this comment.
This seems to be the answer: ethereum-optimism/op-geth#168 (comment)
There was a problem hiding this comment.
Yeah, I think we can get rid of it,
for more context, https://github.com/golang/go/blob/master/src/crypto/elliptic/nistec.go#L129-L134
jwasinger
changed the title
jwasinger
changed the title
|
@alexb5dh I changed the title by mistake. Have corrected it now. This reflects EIP-7951 |
ulerdogan
reviewed
Jun 12, 2025
Comment on lines
+1
to
+9
| [ | ||
| { | ||
| "Input": "4cee90eb86eaa050036147a12d49004b6b9c72bd725d39d4785011fe190f0b4da73bd4903f0ce3b639bbbf6e8e80d16931ff4bcf5993d58468e8fb19086e8cac36dbcd03009df8c59286b162af3bd7fcc0450c9aa81be5d10d312af6c66b1d604aebd3099c618202fcfe16ae7770b0c49ab5eadf74b754204a3bb6060e44eff37618b065f9832de4ca6ca971a7a1adc826d0f7c00181a5fb2ddf79ae00b4e10e", | ||
| "Expected": "0000000000000000000000000000000000000000000000000000000000000001", | ||
| "Gas": 3450, | ||
| "Name": "CallP256Verify", | ||
| "NoBenchmark": false | ||
| } | ||
| ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethereum/EIPs#9833
Based on #27540