Skip to content

fix(BigqueryQuery): Prevent double-wrapping of TIMESTAMP() in SQL generation #9670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tlangton3
Copy link

Updated the SQL generation logic to ensure that TIMESTAMP() is not wrapped in DATETIME() for BigQuery queries. Added regression tests to verify the correct behavior in both standard and SQL pushdown contexts.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

…eration

Updated the SQL generation logic to ensure that TIMESTAMP() is not wrapped in DATETIME() for BigQuery queries. Added regression tests to verify the correct behavior in both standard and SQL pushdown contexts.
@tlangton3 tlangton3 requested review from a team as code owners June 10, 2025 12:48
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant