Merge pull request #40 from Ankit098/fix/false_bool_argument

fix: handle false value in boolean arguments

Author: edwinclement08

browserstack/local.py

@@ -13,6 +13,8 @@ def __xstr(self, key, value):
       return ['']
     if str(value).lower() == "true":
       return ['-' + key]
+    elif str(value).lower() == "false":
+      return ['']
     else:
       return ['-' + key, value]
 

tests/test_local.py

@@ -53,6 +53,11 @@ def test_custom_boolean_argument(self):
     self.assertIn('-boolArg1', self.local._generate_cmd())
     self.assertIn('-boolArg2', self.local._generate_cmd())
 
+  def test_custom_boolean_argument_false(self):
+    self.local.start(boolArg1=False, boolArg2=False, onlyCommand=True)
+    self.assertNotIn('-boolArg1', self.local._generate_cmd())
+    self.assertNotIn('-boolArg2', self.local._generate_cmd())
+
   def test_custom_keyval(self):
     self.local.start(customKey1="custom value1", customKey2="custom value2", onlyCommand=True)
     self.assertIn('-customKey1', self.local._generate_cmd())