Add Local.startSync method #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagpalkaran95
approved these changes
Apr 28, 2022
lib/Local.js
Outdated
| @@ -199,10 +245,10 @@ function Local(){ | |||
| conf.proxyHost = this.proxyHost; | |||
| conf.proxyPort = this.proxyPort; | |||
| } | |||
| this.binary.binaryPath(conf, callback); | |||
| return callback ? this.binary.binaryPath(conf, callback) : this.binary.binaryPath(conf); | |||
There was a problem hiding this comment.
return in case of callback doesn't make sense. Keep this in if else block and return only in case of synchronous call. Same for other similar instances in PR
AdityaHirapara
approved these changes
Apr 29, 2022
bipul21
approved these changes
May 2, 2022
alliv8
reviewed
Jul 14, 2022
| delete(that.binaryPath); | ||
| return that.startSync(options); | ||
| } else { | ||
| return new LocalError(error.toString()); |
There was a problem hiding this comment.
@07souravkunda This should throw an error instead of returning it ~
@francisf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.