Skip to content

build: preserve peerDependenciesMeta in snapshots #30387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

alan-agius4
Copy link
Collaborator

Addresses an issue where publishing snapshot builds would replace the value with the package SHAs in peerDependenciesMeta.

See: https://github.com/angular/angular-build-builds/blob/d4d0f1ca0932bd4fe2df4cc2da10d132789dcd8f/package.json#L89

@alan-agius4 alan-agius4 requested a review from devversion May 26, 2025 08:16
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels May 26, 2025
@alan-agius4 alan-agius4 marked this pull request as ready for review May 26, 2025 08:16
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My script was simpler in total I think, but maybe it didn't work?

@alan-agius4
Copy link
Collaborator Author

My script was simpler in total I think, but maybe it didn't work?

Yes, I didn't work. But I had another look and it's was due to a typo. It works now :)

Addresses an issue where publishing snapshot builds would replace the value with the package SHAs in `peerDependenciesMeta`.

See: https://github.com/angular/angular-build-builds/blob/d4d0f1ca0932bd4fe2df4cc2da10d132789dcd8f/package.json#L89
@alan-agius4 alan-agius4 force-pushed the snapshot-repo-meta branch from e9d64a3 to ff23ae3 Compare May 26, 2025 09:44
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 26, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 26, 2025
@alan-agius4 alan-agius4 merged commit 697d7e6 into angular:main May 26, 2025
31 of 32 checks passed
@alan-agius4 alan-agius4 deleted the snapshot-repo-meta branch May 26, 2025 09:49
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.2.x, 20.0.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants