Skip to content

Differ AudioManager retrieval to whenever AudioFocusManagement is req… #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Differ AudioManager retrieval to whenever AudioFocusManagement is req… #1616

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6af92b0
Differ AudioManager retrieval to whenever AudioFocusManagement is req…
colinkho Aug 13, 2024
0a0444b
Use Suppliers.memoize for lazy instantiation of AudioManager
colinkho Aug 14, 2024
a6f5d3d
Format with google-java-format
icbaker Aug 15, 2024
9c25845
Restore a couple of blank lines
icbaker Aug 20, 2024
bed1dad
Add release note
icbaker Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Restore a couple of blank lines
  • Loading branch information
@icbaker
icbaker committed Aug 20, 2024
commit 9c25845cd799d138993ba2b34e81fc6a0b4fecef
3 changes: 2 additions & 1 deletion libraries/exoplayer/src/main/java/androidx/media3/exoplayer/AudioFocusManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,11 @@ public interface PlayerControl {
private static final float VOLUME_MULTIPLIER_DUCK = 0.2f;
private static final float VOLUME_MULTIPLIER_DEFAULT = 1.0f;

private final AudioFocusListener focusListener;
private final Supplier audioManager;
private final AudioFocusListener focusListener;
@Nullable private PlayerControl playerControl;
@Nullable private AudioAttributes audioAttributes;

private @AudioFocusState int audioFocusState;
private @AudioFocusGain int focusGainToRequest;
private float volumeMultiplier = VOLUME_MULTIPLIER_DEFAULT;
Expand Down