-
Notifications
You must be signed in to change notification settings - Fork 544
Differ AudioManager retrieval to whenever AudioFocusManagement is req… #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6af92b0
Differ AudioManager retrieval to whenever AudioFocusManagement is req…
colinkho 0a0444b
Use Suppliers.memoize for lazy instantiation of AudioManager
colinkho a6f5d3d
Format with google-java-format
icbaker 9c25845
Restore a couple of blank lines
icbaker bed1dad
Add release note
icbaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Differ AudioManager retrieval to whenever AudioFocusManagement is req…
…uired
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIt: you can use Guava's
Suppliers.memoize
for this, to avoid manually needing to check for null, so changeprivate final AudioManager audioManager;
above toprivate final Supplier audioManager;
, change the instantiation to:And then change the usage sites from
audioManager
toaudioManager.get()
Maybe change the field name to
audioManagerSupplier
too - up to you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Will change accordingly