Skip to content

Fixed removal of user info for URLs that contain encoded @ characters #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fixed removal of user info for URLs that contain encoded @ characters #1138

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17e0fd2
Fixed removal of user info for URLs that contain encoded @ characters
Lavamancer Feb 28, 2024
61343cd
Format with google-java-format
microkatz Sep 12, 2024
661f3de
Added note in release notes
microkatz Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format with google-java-format
  • Loading branch information
@microkatz
microkatz committed Sep 12, 2024
commit 61343cd75f336800fe92da620fe1863d419b3819
3 changes: 1 addition & 2 deletions ...ries/exoplayer_rtsp/src/test/java/androidx/media3/exoplayer/rtsp/RtspMessageUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,8 +452,7 @@ public void removeUserInfo_withNoUserInfo() {
@Test
public void removeUserInfo_withEncodedAtInUserInfo() {
Uri uri = Uri.parse("rtsp://user%40name:[email protected]/foo.mkv");
assertThat(RtspMessageUtil.removeUserInfo(uri))
.isEqualTo(Uri.parse("rtsp://foo.bar/foo.mkv"));
assertThat(RtspMessageUtil.removeUserInfo(uri)).isEqualTo(Uri.parse("rtsp://foo.bar/foo.mkv"));
}

@Test
Expand Down