Skip to content

Replacing label with a list of Label elements in Format. #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 27, 2024
Merged

Replacing label with a list of Label elements in Format. #1054

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
df76322
Replacing label with a list of Label elements in Format.
jekopena Jan 30, 2024
63fb68e
Reverting breaking changes by keeping label and adding labels.
jekopena Jan 31, 2024
e9e47f4
Removing id from Label and ensuring label/labels consistency in Forma…
jekopena Mar 12, 2024
5910200
Adding IllegalStateException to Format build and unit tests.
jekopena Mar 13, 2024
0a04e79
Addressing PR feedback.
jekopena Mar 14, 2024
54c23e2
Reverting changes in gradle-wrapper.properties
jekopena Mar 14, 2024
8673e6d
Removing label from toLogString.
jekopena Mar 18, 2024
73c0ebb
Additional clean-up and formatting
tonihei Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing label from toLogString.
  • Loading branch information
@jekopena @tonihei
jekopena authored and tonihei committed Mar 25, 2024
commit 8673e6d39ad28b019d51966e1cf3ca2870e739cd
3 changes: 0 additions & 3 deletions libraries/common/src/main/java/androidx/media3/common/Format.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1338,9 +1338,6 @@ public static String toLogString(@Nullable Format format) {
if (format.language != null) {
builder.append(", language=").append(format.language);
}
if (format.label != null) {
builder.append(", label=").append(format.label);
}
if (format.labels.size() > 0) {
builder.append(", labels=[");
Joiner.on(',').appendTo(builder, format.labels);
Expand Down