Skip to content

Inconsistent currentPosition via MediaBrowser if skip silence is enabled #765

Closed
@JureSencar

Description

@JureSencar

Version

Media3 1.1.1

Devices that reproduce the issue

Pixel 6a Android 13, but I expect the same on all non-legacy controllers

Reproducible in the demo app?

I did not find any spoken audio files in demo app. Music files do not result in significant skip silence effect. Hence, I could not reproduce that using demo app. But it should be straight forward to test. I find this the bug most obvious when listening to an audiobook at e.g. 2x speed with skip silence turned on.

Expected result

Position would jump according to skipped parts due to skip silence.

Actual result

Position is behaving as if skip silence is not enabled. Only after few seconds it jumps to the correct position.
I guess the issue is that the MediaControllerImplBase:maybeUpdateCurrentPositionMs is making estimations based on the playback speed and time elapsed and there are no updates when skip silence occurs.

The position in the underlying Player does not have the the same issue.

Media

Any speech file that has pauses.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions