Skip to content

Commit d3dfc6a

Browse files
icbakercopybara-github
authored andcommitted
Remove COMMAND_CODE_CUSTOM from test controller app
This was added in 697759b based on the assumption it had previously been missing, but actually it is deliberately not included here because it must not be queried against available session commands, as done here: https://github.com/androidx/media/blob/839c4a90f2ab36e48be73e1b5e907f3283dce72e/testapps/controller/src/main/java/androidx/media3/testapp/controller/MediaAppControllerActivity.kt#L299 PiperOrigin-RevId: 756740269
1 parent 533acc8 commit d3dfc6a

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

testapps/controller/src/main/java/androidx/media3/testapp/controller/MediaIntToString.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ object MediaIntToString {
6767
)
6868
val sessionCommandMap =
6969
mapOf(
70-
SessionCommand.COMMAND_CODE_CUSTOM to "COMMAND_CUSTOM",
7170
SessionCommand.COMMAND_CODE_SESSION_SET_RATING to "COMMAND_SESSION_SET_RATING",
7271
SessionCommand.COMMAND_CODE_LIBRARY_GET_LIBRARY_ROOT to "COMMAND_LIBRARY_GET_LIBRARY_ROOT",
7372
SessionCommand.COMMAND_CODE_LIBRARY_SUBSCRIBE to "COMMAND_LIBRARY_SUBSCRIBE",

testapps/controller/src/test/java/androidx/media3/testapp/controller/MediaIntToStringTest.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ class MediaIntToStringTest {
4242
@Test
4343
fun getSessionCommandMap() {
4444
val expectedSessionCommandMap =
45-
getValuesToFieldNameMap(SessionCommand::class.java, "COMMAND_").mapValues { (_, value) ->
46-
value.replace("COMMAND_CODE_", "COMMAND_")
47-
}
45+
getValuesToFieldNameMap(SessionCommand::class.java, "COMMAND_")
46+
.mapValues { (_, value) -> value.replace("COMMAND_CODE_", "COMMAND_") }
47+
.filterValues { it != "COMMAND_CUSTOM" }
4848

4949
assertThat(MediaIntToString.sessionCommandMap).isEqualTo(expectedSessionCommandMap)
5050
}

0 commit comments

Comments
 (0)