Skip to content

Commit bffe2f7

Browse files
committed
Fix 2 ErrorProneStyle findings:
* @Reason is not a TYPE_USE annotation, so should appear before any modifiers and after Javadocs. (see go/java-style#s4.8.5-annotations) * Curly braces should be used for inline Javadoc tags: {@code ...} (see http://go/bugpattern/InvalidInlineTag) This CL looks good? Just LGTM and Approve it! This CL doesn’t look good? This is what you can do: * Revert this CL, by replying "REVERT: " * File a bug under go/error-prone-bug for category ErrorProneStyle if the change looks generally problematic. * Revert this CL and not get a CL that cleans up these paths in the future by replying "BLOCKLIST: ". This is not reversible! We recommend to opt out the respective paths in your CL Robot configuration instead: go/clrobot-opt-out. This CL was generated by CL Robot - a tool that cleans up code findings (go/clrobot). The affected code paths have been enabled for CL Robot in //depot/google3/java/com/google/android/libraries/media/METADATA which is reachable following include_presubmits from //depot/google3/third_party/java_src/android_libs/media/METADATA. Anything wrong with the signup? File a bug at go/clrobot-bug. #codehealth PiperOrigin-RevId: 404769260
1 parent bbe2cef commit bffe2f7

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

library/core/src/main/java/com/google/android/exoplayer2/source/ClippingMediaSource.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public static final class IllegalClippingException extends IOException {
5757
public static final int REASON_START_EXCEEDS_END = 2;
5858

5959
/** The reason clipping failed. */
60-
public final @Reason int reason;
60+
@Reason public final int reason;
6161

6262
/** @param reason The reason clipping failed. */
6363
public IllegalClippingException(@Reason int reason) {

library/core/src/main/java/com/google/android/exoplayer2/source/SinglePeriodTimeline.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ public SinglePeriodTimeline(
147147
* @param isDynamic Whether the window may change when the timeline is updated.
148148
* @param useLiveConfiguration Whether the window is live and {@link MediaItem#liveConfiguration}
149149
* is used to configure live playback behaviour.
150-
* @param manifest The manifest. May be (@code null}.
150+
* @param manifest The manifest. May be {@code null}.
151151
* @param mediaItem A media item used for {@link Timeline.Window#mediaItem}.
152152
*/
153153
public SinglePeriodTimeline(

0 commit comments

Comments
 (0)