"Fix the crash issue when loading the roman_semi_b.ttf font with ResourcesCompat.getFont" #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pCompatTextView when typeface or fontFamily is not set.
…pCompatTextView when typeface or fontFamily is not set.
…and 26" This reverts commit 09b8331.
…Build.VERSION_CODES.P)
yigit
reviewed
Jan 21, 2025
| @@ -50,7 +50,8 @@ androidXMultiplatform { | |||
| sourceSets { | |||
| commonMain { | |||
| dependencies { | |||
| api(project(":lifecycle:lifecycle-runtime")) | |||
| // api(project(":lifecycle:lifecycle-runtime")) | |||
There was a problem hiding this comment.
If I don't modify this line of code, I won't be able to run any unit test methods in TypefaceCompatTest, and it will give the following error.
Could not determine the dependencies of task ':core:core:compileReleaseAndroidTestJavaWithJavac'.
> Could not resolve all dependencies for configuration ':core:core:releaseAndroidTestCompileClasspath'.
> Could not select a variant of project :lifecycle:lifecycle-runtime that matches the consumer attributes.
> Could not find lifecycle-runtime.aar (project :lifecycle:lifecycle-runtime).
Possible solution:
- Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html
There was a problem hiding this comment.
I will revert it and resubmit.
|
thanks, i'm approving this to create the gerrit shadow so it can be reviewed by the owners. |
yigit
approved these changes
Jan 22, 2025
|
gerrit change: to address any future comments, you can still upload new PR versions and they'll be synced to that CL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: TypefaceCompatTest.testRomanSemiB()