Add support for List arguments in typesafe navigation
#725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonderCsabo
requested review from
jbw0033,
ianhanniballake and
claraf3
as code owners
WonderCsabo
force-pushed
the
typesafe-navigation-arg-enum-list
branch
3 times, most recently
from
eb06a5b to
04b4d0b
Compare
|
Hi, thanks for the PR! Can you please also add tests in RouteDecoderTest.kt? It's basically the opposite equivalent of RouteFilledTest. |
Test: ./gradlew navigation:navigation-common:test Test: ./gradlew navigation:navigation-common:cC Test: ./gradlew navigation:navigation-runtime:cC Bug: 375559962
WonderCsabo
force-pushed
the
typesafe-navigation-arg-enum-list
branch
from
04b4d0b to
79289f5
Compare
|
Sure, i added the tests there. |
claraf3
reviewed
Nov 13, 2024
...gation/navigation-common/src/main/java/androidx/navigation/serialization/NavTypeConverter.kt
Show resolved
Hide resolved
ianhanniballake
approved these changes
Nov 19, 2024
|
Thanks so much for fixing this! |
|
@ianhanniballake this fix was released in 2.8.5 and 2.9.0-alpha04, but it is not listed in the release notes. Can you add there, please? |
|
We've added a note to the release notes - thanks again! In the future, note that you can add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add support for List arguments in typesafe navigation
Testing
Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
Issues Fixed
Fixes: 375559962