Skip to content

Add support for List arguments in typesafe navigation #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

WonderCsabo
Copy link
Contributor

Proposed Changes

Add support for List arguments in typesafe navigation

Testing

Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC

Issues Fixed

Fixes: 375559962

@WonderCsabo WonderCsabo force-pushed the typesafe-navigation-arg-enum-list branch 3 times, most recently from eb06a5b to 04b4d0b Compare November 11, 2024 09:00
@claraf3
Copy link
Member

claraf3 commented Nov 12, 2024

Hi, thanks for the PR!

Can you please also add tests in RouteDecoderTest.kt? It's basically the opposite equivalent of RouteFilledTest.

Test: ./gradlew navigation:navigation-common:test
Test: ./gradlew navigation:navigation-common:cC
Test: ./gradlew navigation:navigation-runtime:cC
Bug: 375559962
@WonderCsabo WonderCsabo force-pushed the typesafe-navigation-arg-enum-list branch from 04b4d0b to 79289f5 Compare November 13, 2024 15:48
@WonderCsabo
Copy link
Contributor Author

Sure, i added the tests there.

@ianhanniballake
Copy link
Member

Thanks so much for fixing this!

@WonderCsabo WonderCsabo deleted the typesafe-navigation-arg-enum-list branch November 20, 2024 09:40
@WonderCsabo
Copy link
Contributor Author

@ianhanniballake this fix was released in 2.8.5 and 2.9.0-alpha04, but it is not listed in the release notes. Can you add there, please?

@ianhanniballake
Copy link
Member

We've added a note to the release notes - thanks again!

In the future, note that you can add a Relnote: line in the pull request's description to ensure it gets into the release notes automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants