Skip to content

... #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2020
Merged

... #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1287f29
Update CONTRIBUTING.md
PokhrelAnish Oct 4, 2020
9175b62
Update CONTRIBUTING.md
PokhrelAnish Oct 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
# Contributing

We encourage any form of contribution, whether that be issues, comments, or pull requests. If you are going to be submitting a PR, there are a few things we would appreciate that you do to keep the codebase clean:
We encourage any form of contribution, whether that will be issues, comments, or pull requests. If you are willing to submit a PR, there are a few things we would appreciate that you do to keep the codebase clean:

* **Write tests.** We try as close to 100% code coverage as possible on this repo so any new code that gets written should have accompanying tests.
* **Follow the linter.** We use our [ESLint configuration with Airbnb JavaScript Styleguide](https://github.com/airbnb/javascript), and we run `npm run lint` in our Travis builds.
* **Ask questions if you aren't sure.** If you have any questions while implementing a fix or feature, feel free to create an issue and ask us. We're happy to help!

## <a name="submit">a> Submission Guidelines
## <a name="Submit">a> Submission Guidelines

### <a name="submit-issue">a> Submitting an Issue
### <a name="Submit-issue">a> Submitting an Issue

Before you submit an issue, please search the issue tracker, maybe an issue for your problem already exists and the discussion might inform you of workarounds readily available.

Expand Down Expand Up @@ -188,7 +188,7 @@ Examples of breaking changes include:

We use these three sections in changelog: new features, bug fixes, breaking changes.

List of all subjects (first lines in commit message) since last release:
List of all subjects (First lines in commit message) since last release:

```sh
git log <last tag> HEAD --pretty=format:%s
Expand Down