Skip to content

New rule: First focusable element is link to non-repeated content #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 601 commits into
base: develop
Choose a base branch
from
Draft

New rule: First focusable element is link to non-repeated content #1539

Changes from 1 commit
Commits
Show all changes
601 commits
Select commit Hold shift + click to select a range
6c71f5a
Update def to remove ref to repeated content
Jym77 Aug 27, 2020
5c7182f
Add some detail on name
Jym77 Aug 28, 2020
197900b
Sort references
Jym77 Aug 28, 2020
ac6a3f9
Add rule to detect when bypassing is needed
Jym77 Aug 28, 2020
79ce7ce
Invert repeated content detection rule
Jym77 Aug 28, 2020
c932d1d
Use new atomic rule
Jym77 Aug 28, 2020
78b55a9
Clean up
Jym77 Aug 28, 2020
df90030
Update rule for new composite
Jym77 Aug 28, 2020
0b3df50
Fix spelling and references
Jym77 Aug 28, 2020
f912b2f
Adapt to new version of composite
Jym77 Aug 28, 2020
fd6894d
Do not consider decorative elements
Jym77 Aug 28, 2020
f070cba
Typo
Jym77 Sep 1, 2020
3315c7d
Update rule to new def
Jym77 Sep 1, 2020
093e7c0
Add TODOs
Jym77 Sep 1, 2020
aebd45b
Typo
Jym77 Sep 1, 2020
db390b4
Improve description
Jym77 Sep 1, 2020
4afde93
Fix spelling and references
Jym77 Sep 1, 2020
ad34158
Add examples
Jym77 Sep 1, 2020
ba53305
Correct acknowlodgements
Jym77 Sep 1, 2020
75e5a20
Improve definition
Jym77 Sep 1, 2020
8fe0dcb
Add examples passing rule but not technique
Jym77 Sep 1, 2020
e8e51a2
Remove done TODOs
Jym77 Sep 1, 2020
0080b3a
Fix spelling and references
Jym77 Sep 1, 2020
c369917
Improve example
Jym77 Sep 1, 2020
650ff0b
Improve definition, references block of content
Jym77 Sep 1, 2020
a3c1893
Improve text
Jym77 Sep 1, 2020
0f2694e
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Sep 1, 2020
79d9665
Remove unused note
Jym77 Sep 1, 2020
3d38f19
Remove unused def
Jym77 Sep 1, 2020
8900007
typo
Jym77 Sep 29, 2020
3a153c4
Typo
Jym77 Sep 29, 2020
7e394ad
Typo
Jym77 Sep 29, 2020
e655c66
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Sep 29, 2020
07544a3
Typo
Jym77 Sep 30, 2020
d0f6361
Typo
Jym77 Sep 30, 2020
8b72c67
Typo
Jym77 Sep 30, 2020
60d79a0
Typo
Jym77 Sep 30, 2020
45f598d
Clarification
Jym77 Sep 30, 2020
450583e
typo
Jym77 Sep 30, 2020
0188a47
Typo
Jym77 Sep 30, 2020
b36398d
Typos
Jym77 Sep 30, 2020
742223f
Typo
Jym77 Sep 30, 2020
066cd02
Remove duplicate sentence
Jym77 Sep 30, 2020
7527ecf
Typo
Jym77 Sep 30, 2020
aca3a62
Typo
Jym77 Sep 30, 2020
d0eb519
T
Jym77 Sep 30, 2020
a716d95
Clarification
Jym77 Sep 30, 2020
d8ec162
Improve definition, fix incorrect formulation
Jym77 Sep 30, 2020
50cafc6
Add example with segmentation splitting the main block
Jym77 Sep 30, 2020
5ec43f0
Typo
Jym77 Sep 30, 2020
34c42e8
Explicitely name block used in expectation
Jym77 Sep 30, 2020
5337937
Move notes to Background
Jym77 Sep 30, 2020
fc0352d
Removing markup inside heading
Jym77 Sep 30, 2020
16bd63d
Improve description
Jym77 Sep 30, 2020
f9b5bad
Add example with no linked page
Jym77 Sep 30, 2020
335d6bb
Fix references list
Jym77 Sep 30, 2020
b7a835c
Improve wording.
Jym77 Oct 1, 2020
174aec2
Improve wording
Jym77 Oct 1, 2020
ab503bd
Improve wording
Jym77 Oct 1, 2020
7cce1f6
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Oct 1, 2020
feef4fb
Improve wording
Jym77 Oct 1, 2020
8f9a13a
Improve wording
Jym77 Oct 1, 2020
14d9999
Remane rule and correct input aspects
Jym77 Oct 1, 2020
ac0ea9b
Correct input aspects
Jym77 Oct 1, 2020
307fa94
Improve descriptions
Jym77 Oct 1, 2020
4c4d0c8
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Oct 2, 2020
d62cf15
Improve example descriptions
Jym77 Oct 2, 2020
f710522
Improve example descriptions
Jym77 Oct 2, 2020
c6bec79
Improve example description and remove controversial example
Jym77 Oct 2, 2020
ca32e25
Improve example descriptions
Jym77 Oct 2, 2020
2467666
Improve example descriptions
Jym77 Oct 2, 2020
455e277
Improve ex.ample descriptions
Jym77 Oct 2, 2020
42dc633
Typo
Jym77 Oct 2, 2020
9a4ee4c
Remove unecessary rule
Jym77 Oct 5, 2020
674cf3f
Remove need to jump to blocks after the main section
Jym77 Oct 5, 2020
9a0d4bc
Improve wording
Jym77 Oct 5, 2020
d05140a
Remove failed example that was passing after relaxation
Jym77 Oct 5, 2020
eb49af5
Typo
Jym77 Oct 5, 2020
3b50f5b
Improve examples descriptions
Jym77 Oct 6, 2020
726f28f
Improve examples descriptions
Jym77 Oct 6, 2020
ced6b71
Remove confusing 'only'
Jym77 Oct 6, 2020
7028a5e
Improve descriptions
Jym77 Oct 6, 2020
3450817
Require that instrument can be activated by keyboard
Jym77 Oct 6, 2020
98dbef1
Improve examples description
Jym77 Oct 6, 2020
ae3bedf
Improve example descriptions
Jym77 Oct 6, 2020
4b0775e
Add definition of keyboard actionable + fix links
Jym77 Oct 7, 2020
cc059c6
Add example with empty accessible name
Jym77 Oct 8, 2020
8b087e0
Improve links name and destination
Jym77 Oct 8, 2020
4f04558
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Oct 8, 2020
92e54dc
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Oct 12, 2020
113772d
Create skeleton for new rule
Jym77 Oct 12, 2020
c83ab96
Typo
Jym77 Oct 12, 2020
830d240
Add assumptions and background
Jym77 Oct 12, 2020
02950d4
Add TODOs
Jym77 Oct 12, 2020
c317a75
Add BG note on examples
Jym77 Oct 12, 2020
a95a107
Add passed examples for each technique
Jym77 Oct 13, 2020
052e57e
Improve visible-on-focus styling
Jym77 Oct 13, 2020
1d6eecc
Copy various passed examples
Jym77 Oct 13, 2020
7bdaa66
Add basic failed examples
Jym77 Oct 13, 2020
acd5764
Clean up examples
Jym77 Oct 13, 2020
a5b561a
Clean up examples
Jym77 Oct 13, 2020
1c7fd83
Polish examples descriptions
Jym77 Oct 13, 2020
d559126
move TODO note
Jym77 Oct 13, 2020
165fbf0
Fix spelling and references
Jym77 Oct 13, 2020
5472fff
Remove unused rules
Jym77 Oct 13, 2020
aeae1c3
Use new rule
Jym77 Oct 13, 2020
95ee404
Move example not fulfilling mapping
Jym77 Oct 13, 2020
921d925
Remove accessibility tree requirement from actionable
Jym77 Oct 13, 2020
1d03500
Add TODO
Jym77 Oct 13, 2020
e9cbb8a
Use new def
Jym77 Oct 13, 2020
8f7c63a
Improve code
Jym77 Oct 13, 2020
6e3b840
Rework examples
Jym77 Oct 13, 2020
415b1e6
Add passing cases that do not pass the techniques
Jym77 Oct 13, 2020
616734c
Renumber examples
Jym77 Oct 13, 2020
9073eb2
Fix spelling and references
Jym77 Oct 13, 2020
070002e
Correct name
Jym77 Oct 13, 2020
ea37046
Polish description and add missing examples
Jym77 Oct 13, 2020
4664b45
Delete unused definitions
Jym77 Oct 13, 2020
d9bfd8f
Fix spelling and references
Jym77 Oct 13, 2020
6cb6c06
Clean up examples
Jym77 Oct 13, 2020
228c1a9
Clean up
Jym77 Oct 13, 2020
a4e25a9
Clean up
Jym77 Oct 13, 2020
6cfb0cf
Clean up examples
Jym77 Oct 13, 2020
c09f766
Clean up
Jym77 Oct 13, 2020
fb3e830
Polish examples
Jym77 Oct 13, 2020
d3cf68b
Typos
Jym77 Oct 13, 2020
eb62aee
Clean up examples and descriptions
Jym77 Oct 13, 2020
4ea3fab
Fix references
Jym77 Oct 13, 2020
e9e2946
Remove definition of at the end
Jym77 Oct 14, 2020
d38f9f3
Clean up
Jym77 Oct 14, 2020
bd68ce1
Use definition of semantic link
Jym77 Oct 14, 2020
7a2feb1
Clean up onclick attributes
Jym77 Oct 14, 2020
a3fbad4
Add assumptions about language where needed
Jym77 Oct 14, 2020
433fb25
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Oct 14, 2020
22d3adb
Apply proofreading suggestions from code review
Jym77 Oct 19, 2020
f87a0f8
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Oct 19, 2020
26e2cb9
Fix atomic rule name in references
Jym77 Oct 19, 2020
af44488
Remove duplicated example
Jym77 Oct 19, 2020
05e4f27
Move example to atomic rule
Jym77 Oct 19, 2020
994f448
Remove duplicated condition
Jym77 Oct 19, 2020
9101b06
Fix references list
Jym77 Oct 19, 2020
54855d3
Use italics for rules names
Jym77 Oct 19, 2020
bf57d85
Precise that sequential focus order is to be used
Jym77 Oct 19, 2020
8b05940
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Oct 23, 2020
dc595d8
Focus expectations on sequential focus order
Jym77 Oct 23, 2020
38b11b8
Add example with no main element
Jym77 Oct 27, 2020
c3ac783
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Nov 6, 2020
71690a6
Improve the non-presentational requirement
Jym77 Nov 6, 2020
ee7460e
Upated conditional list syntax
Jym77 Nov 6, 2020
abad841
Typo
Jym77 Nov 6, 2020
7ec1b71
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Nov 13, 2020
75ed7bd
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Nov 17, 2020
cbe9c54
Cleanup
Jym77 Nov 17, 2020
0099735
Cleanup
Jym77 Nov 17, 2020
64041bf
Rephrase expectations to strictly adhere to condtional list syntax
Jym77 Nov 17, 2020
3c093f1
Remove
and headings from examples
Jym77 Nov 17, 2020
0d44223
Curate reference lists
Jym77 Nov 17, 2020
a535bb0
Move assumption and add details
Jym77 Nov 17, 2020
cc19714
Explicit content of block
Jym77 Nov 17, 2020
7822a08
Add precision on different URL
Jym77 Nov 17, 2020
ee3d052
Curate reference list
Jym77 Nov 17, 2020
7a97ecb
Remove unused definition
Jym77 Nov 17, 2020
73150a8
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Nov 26, 2020
0b043cb
Remove bold fake headings
Jym77 Nov 26, 2020
f9973dc
Remove unused references
Jym77 Nov 26, 2020
dee6f17
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Dec 1, 2020
3370125
Typos
Jym77 Dec 2, 2020
5ca8d42
Remove refs to main block of content
Jym77 Dec 2, 2020
5cbbd55
Clean up
Jym77 Dec 2, 2020
1815388
Remove refs to main block of content
Jym77 Dec 2, 2020
29df2bd
Remove ref to main block of content
Jym77 Dec 2, 2020
4a3d65a
Create definition of at the end
Jym77 Dec 2, 2020
8545433
Remove refs to main section, replace at the start by at the end
Jym77 Dec 2, 2020
94ca082
Clean up
Jym77 Dec 2, 2020
75312d7
Clean up
Jym77 Dec 2, 2020
a178fde
Remove refs to main block of content and at the start
Jym77 Dec 2, 2020
5d7ad65
Clean up
Jym77 Dec 2, 2020
5c42e51
Clean up
Jym77 Dec 2, 2020
752813c
Remove ref to main block of content and at the start
Jym77 Dec 2, 2020
fa4cc35
Clean up
Jym77 Dec 2, 2020
b306489
Remove unused defs
Jym77 Dec 2, 2020
7724f1a
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Dec 8, 2020
500cb33
Add definition of just before a node
Jym77 Dec 9, 2020
6fee229
Rename composite rule
Jym77 Dec 9, 2020
7c1d796
Move granularity to node level
Jym77 Dec 10, 2020
4dea66e
Add definition of non-repeated content
Jym77 Dec 10, 2020
e7bb323
Move link target to any non-repeated content
Jym77 Dec 10, 2020
37776a5
Uopdate examples
Jym77 Dec 10, 2020
fc7cc4f
Remove unused definition
Jym77 Dec 10, 2020
53218b4
Revert changes
Jym77 Dec 10, 2020
4260fab
Use non-repeated content
Jym77 Dec 10, 2020
3bf39bd
Remove unused definition
Jym77 Dec 10, 2020
45da952
Rename rule
Jym77 Dec 10, 2020
4788b25
Typo
Jym77 Dec 10, 2020
bc74119
Accept an heading as OK
Jym77 Dec 10, 2020
10b36b8
Require heading anywhere in non-repeated content
Jym77 Dec 10, 2020
c9b53e4
Rename rule
Jym77 Dec 11, 2020
ef1c612
Only require instrument to some non-repeated content, not first.
Jym77 Dec 11, 2020
be5ace7
Typos
Jym77 Dec 11, 2020
8ca9afd
Remove unused definition
Jym77 Dec 11, 2020
db524ab
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Dec 17, 2020
a8a169c
Apply proofreading suggestions from code review
Jym77 Dec 17, 2020
54ff945
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Dec 17, 2020
bbf5e2b
Typo
Jym77 Dec 18, 2020
880b9de
Fix bad copy/paste
Jym77 Dec 18, 2020
33fc83d
Fix requirement on link name
Jym77 Dec 18, 2020
9995661
Remove useless precision
Jym77 Dec 18, 2020
e53d3ee
Remove extra requirements on instruments
Jym77 Dec 18, 2020
1507e4c
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Dec 22, 2020
7ca6422
Rename definition
Jym77 Dec 22, 2020
1bc6110
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Jan 7, 2021
ba55686
Apply suggestions from code review
Jym77 Jan 7, 2021
18ecd79
Reverse inclusion in expectation + explicitly pass if no repeated con…
Jym77 Jan 7, 2021
a069767
Fix expectation
Jym77 Jan 7, 2021
700c6e6
Add example with no repeated content
Jym77 Jan 7, 2021
4ea0e93
Correct example numbering
Jym77 Jan 7, 2021
8220237
Clean up example
Jym77 Jan 7, 2021
59f4d98
Rename and adapt rule
Jym77 Jan 7, 2021
547970a
Adapt name
Jym77 Jan 7, 2021
c0faec3
Remove unused reference
Jym77 Jan 7, 2021
2201f72
Polish background note
Jym77 Jan 7, 2021
58a7260
Correct name
Jym77 Jan 7, 2021
0198231
Adapt to new rule name
Jym77 Jan 7, 2021
dfd11cb
Fix reference lists
Jym77 Jan 7, 2021
5c0bb11
Rephrase assumption and background
Jym77 Jan 15, 2021
bdf55db
Typo
Jym77 Jan 15, 2021
e6d7f6e
Apply editorial suggestions from code review
Jym77 Jan 18, 2021
07937ff
Clarify false positive
Jym77 Jan 18, 2021
2121b2c
Typo
Jym77 Jan 18, 2021
93266e9
Apply suggestions from code review
Jym77 Jan 19, 2021
a6cad25
Drop controversial example with aria-hidden focusable element
Jym77 Jan 19, 2021
f919671
Fix references list
Jym77 Jan 19, 2021
ecd39ad
Merge branch 'develop' into rule-cf77f2-bypass-blocks
Jym77 Jan 22, 2021
99e5ce0
Remove unrelated rules
Jym77 Jan 22, 2021
d035565
Remove unused assets
Jym77 Jan 22, 2021
bfa465c
Merge branch 'develop' into first-focusable-is-link-to-main
Jym77 Mar 11, 2021
ef1fca8
Clean up
Jym77 Mar 11, 2021
26fe82c
Fix paths to test assets
Jym77 Mar 11, 2021
bb81409
Merge branch 'develop' into first-focusable-is-link-to-main
Jym77 Apr 6, 2021
b7079f2
Merge branch 'develop' into first-focusable-is-link-to-main
Jym77 May 20, 2021
c692dcd
Apply only to pages with focusable element, and pass if no repeated c…
Jym77 May 20, 2021
e628044
Revert extra line
Jym77 May 20, 2021
115cef7
Revert extra line
Jym77 May 20, 2021
0148dd4
Revert change
Jym77 May 20, 2021
d347c50
Revert changes
Jym77 May 20, 2021
beb9c40
Revert new line at end of file
Jym77 May 20, 2021
452eae9
notes
Jym77 May 20, 2021
3c0f37f
Make rule composite
Jym77 May 27, 2021
826091d
Clean up
Jym77 May 27, 2021
5459648
Merge branch 'develop' into first-focusable-is-link-to-main
Jym77 May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'develop' into first-focusable-is-link-to-main
  • Loading branch information
@Jym77
Jym77 committed May 27, 2021
commit 5459648006c0a80f54da6074b5a6eaf4b2c42ae5

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.