-
Notifications
You must be signed in to change notification settings - Fork 75
Resolve TF feedback on "Object has accessible name" 8fc3b6 #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve TF feedback on "Object has accessible name" 8fc3b6 #1441
Conversation
wcag20:1.1.1: # Non-text Content (A) | ||
forConformance: true | ||
failed: not satisfied | ||
passed: further testing needed | ||
inapplicable: further testing needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of removing the mapping, I think we should fix that sometimes this rule is failing the wrong SC. I think the simplest way to do this is to either add an assumption, or exclude objects with certain types of content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconding @WilcoFiers comment.
Updated applicability to consider only image, audio or video resources and reinstated SC 1.1.1 |
Changes made
@@ -18,7 +23,7 @@ acknowledgments: | |||
|
|||
## Applicability | |||
|
|||
This rule applies to any `object` element that is [included in the accessibility tree][]. | |||
This rule applies to any `object` element that is [included in the accessibility tree][] and embeds a resource with an [image MIME type](https://mimesniff.spec.whatwg.org/#image-mime-type) or an [audio or video MIME type](https://mimesniff.spec.whatwg.org/#audio-or-video-mime-type). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that ❤️ It does raise a few questions…
- Should we have examples with a
type
attribute? - How is the type determined without
type
attribute? Looks like it is step 8 in the algo at https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-object-element which is somewhat complex :-/
The question is especially relevant in "are we sure that the examples are going to be served with the correct MIME type?" - Can we add more types to this list (e.g. archives, fonts, …)? This is definitely not needed for the validity of the rule…
I think it might be worth to add a definition of "non-text MIME type" which would them be easy to update if needed (plus, can be reused, and makes the intention super clear in that rule: "anobject
which embeds a [non-text][non-text mime] resource")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jym77 I'll start by addressing question 2 and then 1 (before question 3)
-
I don't think we should dive into the algorithm (similar to what we do with accessible names, for instance). The browser determines the mime type of the resource (in the same way it builds the accessibility tree). I admit I haven't looked into the details of the process, but by looking at the headers in the HTTP response to the request for the object, the mime type is there and it is the correct one for all the examples we have.
Furthermore, even when I enter an incorrect mime type using the type attribute, I made two observations: 1) the response headers always have the correct type (ignoring what I entered in the type attribute); 2) the browser always renders the object correctly, apparently also ignoring the type attribute. -
Given the observations above, I don't really think we need to have examples with the type attribute, because it doesn't seem to be used for any rendering decisions.
-
Not sure it that would be useful. SC 1.1.1 addresses non-text content that is presented to the user. Fonts and archives are not really presented to user, are they? And if they are, I supposed they would be presented as text. By including those, we then would have to write the applicability in a way to leave them out.
I'll wait for your input, to understand if you think we still need to change anything in the rule!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with that 👍
Request for further discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issue
Co-authored-by: Wilco Fiers
This `object` element embeds an HTML resource. | ||
|
||
```html | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This unusual scenario feels similar to an iframe. Just double checking, but presume for this rule/example it wouldn't matter if the HTML resource was non-text content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is similar to an iframe (I seem to remember one of the browsers even treating this as an iframe in the DOM).
The rule was revised to be applicable only to images, audio or video mime types. That's why this was moved to an Inapplicable example.
Do let me know if you wish to change your approval!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems OK. I've asked a question, but suspect the response won't affect approval.
Final call ends October 5 |
Final call ended. Merging |
Processing TF feedback in w3c/wcag-act#479
Closes issue(s):
Need for Final Call:
This will require a 1 week Final Call (added assumption, small changes to test cases)
Pull Request Etiquette
How to Review And Approve