-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[py] Fix FedCM tests leaking state #15583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The test failures in CI have nothing to do with this PR... I will investigate them separately. |
User description
🔗 Related Issues
Fixes #15581
💥 What does this PR do?
This fixes an issue where FedCM tests were failing in the internal Python test suite located in
py/test/selenium/webdriver/common/fedcm_tests.py
.The tests would open the FedCM dialog, but never close it... which would lead to subsequent tests failing in odd ways. This PR adds code to dismiss the dialog in several tests after the test completes. Now state is not leaked and all tests pass.
🔄 Types of changes
PR Type
Bug fix, Tests
Description
Fixes FedCM tests leaking state by dismissing dialogs.
Adds
dialog.dismiss()
to multiple test cases to ensure cleanup.Resolves test failures caused by unclosed FedCM dialogs.
Changes walkthrough 📝
fedcm_tests.py
Add dialog dismissal to FedCM tests
py/test/selenium/webdriver/common/fedcm_tests.py
dialog.dismiss()
to ensure dialogs are closed after tests.