Update safe-links-about.md Mostly clarifying the 'do not rewrite' fun… #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction. Added scenario to explain no-rewrite option. Line 110: first sentence implies scan happens before rewrite. second implied it only happens after rewrite. Changed this to clarify what it means. Line 112: I do not think this is true anymore... In new Outlook with html rendering, I get long Microsoft URLs, and the email layout is changed significantly. On Outlook OTW with whatever the defaults are, same. I'm not sure if something different is meant by 'standard view', so these are just striked. I've only ever seen links be visibly rewritten (except for links set to not rewrite) 121: Added clarity for what different configs do. 141: clarity 246: I'm not certain about this - I'm assuming this is what is meant. I would not imagine SafeLinks blocks navigation to URLs that are detected to be safe. Line 114: just bad grammar
|
Learn Build status updates of commit 8715f1d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit 1621ead: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ction.
Added scenario to explain no-rewrite option, and potential vulnerability..
Line 110: first sentence implies scan happens before rewrite. second implied it only happens after rewrite. Changed this to clarify what it means.
Line 112: I do not think this is true anymore... In new Outlook with html rendering, I get long Microsoft URLs, and the email layout is changed significantly. On Outlook OTW with whatever the defaults are, same. I'm not sure if something different is meant by 'standard view', so these are just striked. I've only ever seen links be visibly rewritten (except for links set to not rewrite)
121: Added clarity for what different configs do.
141: clarity
246: I'm not certain about this - I'm assuming this is what is meant. I would not imagine SafeLinks blocks navigation to URLs that are detected to be safe.
Line 114: just bad grammar