servo: Merge #16334 - Stylo - support image-orientation property (from chenpighead:stylo-image-orientation-support); r=bholley

First, we need to make Servo's image-orientation parser to be agreed with Gecko's.
Numbers without any AngleUnit, including unitless 0 angle, should be invalid
for image-orientation. However, rotate() and skew() for transform properties
accept unitless 0 angle. In order to make all these properties work properly,
I fixed Angle::parse() to match Gecko. For the existing users of Angle::parse(),
I create Angle::parse_with_unitless() and use it as an alternative for them.
Once w3c/csswg-drafts#1162 is resolved, we shall be
able to use an unified version of Angle::parse() then.

The parser of image-orientation is also fixed to report parsing errors on
empty string.

Then, with the newly added binding functions support in Gecko side, we shall
reuse the same methods from Gecko to pass the computed value from Servo to Gecko.

Gecko bug: Bug 1341758



---

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).


- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____





Source-Repo: https://github.com/servo/servo
Source-Revision: 2544c085214f368ec0a189bd8aefd7d83f75563b

Author: chenpighead

servo/components/style/gecko_bindings/bindings.rs

@@ -704,6 +704,18 @@ extern "C" {
 extern "C" {
     pub fn Gecko_CopyFontFamilyFrom(dst: *mut nsFont, src: *const nsFont);
 }
+extern "C" {
+    pub fn Gecko_SetImageOrientation(aVisibility: *mut nsStyleVisibility,
+                                     aRadians: f64, aFlip: bool);
+}
+extern "C" {
+    pub fn Gecko_SetImageOrientationAsFromImage(aVisibility:
+                                                    *mut nsStyleVisibility);
+}
+extern "C" {
+    pub fn Gecko_CopyImageOrientationFrom(aDst: *mut nsStyleVisibility,
+                                          aSrc: *const nsStyleVisibility);
+}
 extern "C" {
     pub fn Gecko_SetListStyleType(style_struct: *mut nsStyleList, type_: u32);
 }

servo/components/style/gecko_bindings/structs_debug.rs

@@ -23700,6 +23700,8 @@ pub mod root {
         pub mModeFlags: root::nsStyleImageRequest_Mode,
         pub mResolved: bool,
     }
+    pub type nsStyleImageRequest_URLValueData =
+        root::mozilla::css::URLValueData;
     #[repr(u8)]
     #[derive(Debug, Copy, Clone, PartialEq, Eq, Hash)]
     pub enum nsStyleImageRequest_Mode { Track = 1, Discard = 2, }
@@ -23758,6 +23760,7 @@ pub mod root {
         eStyleImageType_Image = 1,
         eStyleImageType_Gradient = 2,
         eStyleImageType_Element = 3,
+        eStyleImageType_URL = 4,
     }
     #[repr(C)]
     #[derive(Debug)]
@@ -23808,11 +23811,14 @@ pub mod root {
 
                                                 root::mozilla::DefaultDelete>,
     }
+    pub type nsStyleImage_URLValue = root::mozilla::css::URLValue;
+    pub type nsStyleImage_URLValueData = root::mozilla::css::URLValueData;
     #[repr(C)]
     #[derive(Debug, Copy)]
     pub struct nsStyleImage__bindgen_ty_1 {
         pub mImage: root::__BindgenUnionField<*mut root::nsStyleImageRequest>,
         pub mGradient: root::__BindgenUnionField<*mut root::nsStyleGradient>,
+        pub mURLValue: root::__BindgenUnionField<*mut root::nsStyleImage_URLValue>,
         pub mElementId: root::__BindgenUnionField<*mut u16>,
         pub bindgen_union_field: u64,
     }
@@ -23838,6 +23844,12 @@ pub mod root {
                     "Alignment of field: " , stringify ! (
                     nsStyleImage__bindgen_ty_1 ) , "::" , stringify ! (
                     mGradient ) ));
+        assert_eq! (unsafe {
+                    & ( * ( 0 as * const nsStyleImage__bindgen_ty_1 ) ) .
+                    mURLValue as * const _ as usize } , 0usize , concat ! (
+                    "Alignment of field: " , stringify ! (
+                    nsStyleImage__bindgen_ty_1 ) , "::" , stringify ! (
+                    mURLValue ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImage__bindgen_ty_1 ) ) .
                     mElementId as * const _ as usize } , 0usize , concat ! (
@@ -24066,7 +24078,6 @@ pub mod root {
     #[derive(Debug)]
     pub struct nsStyleImageLayers_Layer {
         pub mImage: root::nsStyleImage,
-        pub mSourceURI: root::RefPtr,
         pub mPosition: root::mozilla::Position,
         pub mSize: root::nsStyleImageLayers_Size,
         pub mClip: root::nsStyleImageLayers_Layer_StyleGeometryBox,
@@ -24081,8 +24092,8 @@ pub mod root {
             nsStyleImageLayers_Layer_StyleGeometryBox;
     #[test]
     fn bindgen_test_layout_nsStyleImageLayers_Layer() {
-        assert_eq!(::std::mem::size_of::() ,
-                   104usize , concat ! (
+        assert_eq!(::std::mem::size_of::() , 96usize
+                   , concat ! (
                    "Size of: " , stringify ! ( nsStyleImageLayers_Layer ) ));
         assert_eq! (::std::mem::align_of::() ,
                     8usize , concat ! (
@@ -24096,61 +24107,55 @@ pub mod root {
                     ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) .
-                    mSourceURI as * const _ as usize } , 32usize , concat ! (
-                    "Alignment of field: " , stringify ! (
-                    nsStyleImageLayers_Layer ) , "::" , stringify ! (
-                    mSourceURI ) ));
-        assert_eq! (unsafe {
-                    & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) .
-                    mPosition as * const _ as usize } , 40usize , concat ! (
+                    mPosition as * const _ as usize } , 32usize , concat ! (
                     "Alignment of field: " , stringify ! (
                     nsStyleImageLayers_Layer ) , "::" , stringify ! (
                     mPosition ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) . mSize
-                    as * const _ as usize } , 64usize , concat ! (
+                    as * const _ as usize } , 56usize , concat ! (
                     "Alignment of field: " , stringify ! (
                     nsStyleImageLayers_Layer ) , "::" , stringify ! ( mSize )
                     ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) . mClip
-                    as * const _ as usize } , 92usize , concat ! (
+                    as * const _ as usize } , 84usize , concat ! (
                     "Alignment of field: " , stringify ! (
                     nsStyleImageLayers_Layer ) , "::" , stringify ! ( mClip )
                     ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) .
-                    mOrigin as * const _ as usize } , 93usize , concat ! (
+                    mOrigin as * const _ as usize } , 85usize , concat ! (
                     "Alignment of field: " , stringify ! (
                     nsStyleImageLayers_Layer ) , "::" , stringify ! ( mOrigin
                     ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) .
-                    mAttachment as * const _ as usize } , 94usize , concat ! (
+                    mAttachment as * const _ as usize } , 86usize , concat ! (
                     "Alignment of field: " , stringify ! (
                     nsStyleImageLayers_Layer ) , "::" , stringify ! (
                     mAttachment ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) .
-                    mBlendMode as * const _ as usize } , 95usize , concat ! (
+                    mBlendMode as * const _ as usize } , 87usize , concat ! (
                     "Alignment of field: " , stringify ! (
                     nsStyleImageLayers_Layer ) , "::" , stringify ! (
                     mBlendMode ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) .
-                    mComposite as * const _ as usize } , 96usize , concat ! (
+                    mComposite as * const _ as usize } , 88usize , concat ! (
                     "Alignment of field: " , stringify ! (
                     nsStyleImageLayers_Layer ) , "::" , stringify ! (
                     mComposite ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) .
-                    mMaskMode as * const _ as usize } , 97usize , concat ! (
+                    mMaskMode as * const _ as usize } , 89usize , concat ! (
                     "Alignment of field: " , stringify ! (
                     nsStyleImageLayers_Layer ) , "::" , stringify ! (
                     mMaskMode ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleImageLayers_Layer ) ) .
-                    mRepeat as * const _ as usize } , 98usize , concat ! (
+                    mRepeat as * const _ as usize } , 90usize , concat ! (
                     "Alignment of field: " , stringify ! (
                     nsStyleImageLayers_Layer ) , "::" , stringify ! ( mRepeat
                     ) ));
@@ -24167,7 +24172,7 @@ pub mod root {
     }
     #[test]
     fn bindgen_test_layout_nsStyleImageLayers() {
-        assert_eq!(::std::mem::size_of::() , 160usize ,
+        assert_eq!(::std::mem::size_of::() , 152usize ,
                    concat ! ( "Size of: " , stringify ! ( nsStyleImageLayers )
                    ));
         assert_eq! (::std::mem::align_of::() , 8usize ,
@@ -24248,7 +24253,7 @@ pub mod root {
     }
     #[test]
     fn bindgen_test_layout_nsStyleBackground() {
-        assert_eq!(::std::mem::size_of::() , 168usize ,
+        assert_eq!(::std::mem::size_of::() , 160usize ,
                    concat ! ( "Size of: " , stringify ! ( nsStyleBackground )
                    ));
         assert_eq! (::std::mem::align_of::() , 8usize ,
@@ -24261,7 +24266,7 @@ pub mod root {
                     , "::" , stringify ! ( mImage ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleBackground ) ) .
-                    mBackgroundColor as * const _ as usize } , 160usize ,
+                    mBackgroundColor as * const _ as usize } , 152usize ,
                     concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleBackground )
                     , "::" , stringify ! ( mBackgroundColor ) ));
@@ -26362,7 +26367,7 @@ pub mod root {
     }
     #[test]
     fn bindgen_test_layout_nsStyleSVGReset() {
-        assert_eq!(::std::mem::size_of::() , 200usize ,
+        assert_eq!(::std::mem::size_of::() , 192usize ,
                    concat ! ( "Size of: " , stringify ! ( nsStyleSVGReset )
                    ));
         assert_eq! (::std::mem::align_of::() , 8usize ,
@@ -26375,48 +26380,48 @@ pub mod root {
                     "::" , stringify ! ( mMask ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleSVGReset ) ) . mClipPath as *
-                    const _ as usize } , 160usize , concat ! (
+                    const _ as usize } , 152usize , concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleSVGReset ) ,
                     "::" , stringify ! ( mClipPath ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleSVGReset ) ) . mStopColor as *
-                    const _ as usize } , 176usize , concat ! (
+                    const _ as usize } , 168usize , concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleSVGReset ) ,
                     "::" , stringify ! ( mStopColor ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleSVGReset ) ) . mFloodColor as
-                    * const _ as usize } , 180usize , concat ! (
+                    * const _ as usize } , 172usize , concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleSVGReset ) ,
                     "::" , stringify ! ( mFloodColor ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleSVGReset ) ) . mLightingColor
-                    as * const _ as usize } , 184usize , concat ! (
+                    as * const _ as usize } , 176usize , concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleSVGReset ) ,
                     "::" , stringify ! ( mLightingColor ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleSVGReset ) ) . mStopOpacity as
-                    * const _ as usize } , 188usize , concat ! (
+                    * const _ as usize } , 180usize , concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleSVGReset ) ,
                     "::" , stringify ! ( mStopOpacity ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleSVGReset ) ) . mFloodOpacity
-                    as * const _ as usize } , 192usize , concat ! (
+                    as * const _ as usize } , 184usize , concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleSVGReset ) ,
                     "::" , stringify ! ( mFloodOpacity ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleSVGReset ) ) .
-                    mDominantBaseline as * const _ as usize } , 196usize ,
+                    mDominantBaseline as * const _ as usize } , 188usize ,
                     concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleSVGReset ) ,
                     "::" , stringify ! ( mDominantBaseline ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleSVGReset ) ) . mVectorEffect
-                    as * const _ as usize } , 197usize , concat ! (
+                    as * const _ as usize } , 189usize , concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleSVGReset ) ,
                     "::" , stringify ! ( mVectorEffect ) ));
         assert_eq! (unsafe {
                     & ( * ( 0 as * const nsStyleSVGReset ) ) . mMaskType as *
-                    const _ as usize } , 198usize , concat ! (
+                    const _ as usize } , 190usize , concat ! (
                     "Alignment of field: " , stringify ! ( nsStyleSVGReset ) ,
                     "::" , stringify ! ( mMaskType ) ));
     }