Rename PQtraceSetFlags() to PQsetTraceFlags().

We have a dozen PQset*() functions.  PQresultSetInstanceData() and this
were the libpq setter functions having a different word order.  Adopt
the majority word order.

Reviewed by Alvaro Herrera and Robert Haas, though this choice of name
was not unanimous.

Discussion: https://postgr.es/m/20210605060555[email protected]

diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 9e6e085385466656ea82ce9d620e313778bbcc3e..6b96f30dccaa9c235db261eb290f267005cf68d8 100644 (file)
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -6533,14 +6533,14 @@ void PQtrace(PGconn *conn, FILE *stream);
     
    
 
-   traceSetFlags">
-    PQtraceSetFlagsPQtraceSetFlags
+   setTraceFlags">
+    PQsetTraceFlagsPQtraceSetFlags
 
     
      
       Controls the tracing behavior of client/server communication.
 
-void PQtraceSetFlags(PGconn *conn, int flags);
+void PQsetTraceFlags(PGconn *conn, int flags);
 
      
 

diff --git a/src/interfaces/libpq/exports.txt b/src/interfaces/libpq/exports.txt
index 9ef99f6de127bb5495ebfc03efad559be7f5fdcb..824a03ffbdc88f2c72d92752828583c59f74eb9c 100644 (file)
--- a/src/interfaces/libpq/exports.txt
+++ b/src/interfaces/libpq/exports.txt
@@ -183,5 +183,5 @@ PQenterPipelineMode       180
 PQexitPipelineMode        181
 PQpipelineSync            182
 PQpipelineStatus          183
-PQtraceSetFlags           184
+PQsetTraceFlags           184
 PQmblenBounded              185

diff --git a/src/interfaces/libpq/fe-trace.c b/src/interfaces/libpq/fe-trace.c
index 76a6d1ebe2d5c12e0c78d9d59613bba12856c6b7..8660d27926e8bfa29073d00c4398572648273a91 100644 (file)
--- a/src/interfaces/libpq/fe-trace.c
+++ b/src/interfaces/libpq/fe-trace.c
@@ -61,7 +61,7 @@ PQuntrace(PGconn *conn)
 
 /* Set flags for current tracing session */
 void
-PQtraceSetFlags(PGconn *conn, int flags)
+PQsetTraceFlags(PGconn *conn, int flags)
 {
    if (conn == NULL)
        return;

diff --git a/src/interfaces/libpq/libpq-fe.h b/src/interfaces/libpq/libpq-fe.h
index ca733a2004835887332043ee4ea69efe42e414d8..ec378705ad75f241206e756401b94bef939bed07 100644 (file)
--- a/src/interfaces/libpq/libpq-fe.h
+++ b/src/interfaces/libpq/libpq-fe.h
@@ -403,7 +403,7 @@ extern void PQuntrace(PGconn *conn);
 #define PQTRACE_SUPPRESS_TIMESTAMPS        (1<<0)
 /* redact portions of some messages, for testing frameworks */
 #define PQTRACE_REGRESS_MODE           (1<<1)
-extern void PQtraceSetFlags(PGconn *conn, int flags);
+extern void PQsetTraceFlags(PGconn *conn, int flags);
 
 /* === in fe-exec.c === */
 

diff --git a/src/test/modules/libpq_pipeline/libpq_pipeline.c b/src/test/modules/libpq_pipeline/libpq_pipeline.c
index e4bba103ed1123a220abb303065bd4d2814a6d9a..71eedb6dbb4b8285dfe287bf4cf745e2803f43a6 100644 (file)
--- a/src/test/modules/libpq_pipeline/libpq_pipeline.c
+++ b/src/test/modules/libpq_pipeline/libpq_pipeline.c
@@ -1326,7 +1326,7 @@ main(int argc, char **argv)
        setvbuf(trace, NULL, PG_IOLBF, 0);
 
        PQtrace(conn, trace);
-       PQtraceSetFlags(conn,
+       PQsetTraceFlags(conn,
                        PQTRACE_SUPPRESS_TIMESTAMPS | PQTRACE_REGRESS_MODE);
    }