Fix off-by-one error in Assertion.

The point of the assertion is to ensure that the arrays allocated in stack
are large enough, but the check was one item short.

This won't matter in practice because MaxIndexTuplesPerPage is an
overestimate, so you can't have that many items on a page in reality.
But let's be tidy.

Spotted by Anastasia Lubennikova. Backpatch to all supported versions, like
the patch that added the assertion.

diff --git a/src/backend/storage/page/bufpage.c b/src/backend/storage/page/bufpage.c
index 93fdb54fded1ef8968c47addb3092aa37bace6a0..c95eb792a084be6a4a36d7f8e2dbd319563fd74a 100644 (file)
--- a/src/backend/storage/page/bufpage.c
+++ b/src/backend/storage/page/bufpage.c
@@ -778,7 +778,7 @@ PageIndexMultiDelete(Page page, OffsetNumber *itemnos, int nitems)
    int         nextitm;
    OffsetNumber offnum;
 
-   Assert(nitems < MaxIndexTuplesPerPage);
+   Assert(nitems <= MaxIndexTuplesPerPage);
 
    /*
     * If there aren't very many items to delete, then retail