Add HINT for restartpoint race with KeepFileRestoredFromArchive().

The five commits ending at cc2c7d65fc27e877c9f407587b0b92d46cd6dd16
closed this race condition for v15+.  For v14 through v10, add a HINT to
discourage studying the cosmetic problem.

Reviewed by Kyotaro Horiguchi and David Steele.

Discussion: https://postgr.es/m/20220731061747[email protected]

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index b9c130bcccbe5745c4d143259c2ba601a30d231e..29e94f3102a004db2aa7fa3fcb1de6652f31d496 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -3436,7 +3436,10 @@ XLogFileInit(XLogSegNo logsegno, bool *use_existent, bool use_lock)
    if (fd < 0)
        ereport(ERROR,
                (errcode_for_file_access(),
-                errmsg("could not open file \"%s\": %m", path)));
+                errmsg("could not open file \"%s\": %m", path),
+                (AmCheckpointerProcess() ?
+                 errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :
+                 0)));
 
    elog(DEBUG2, "done creating and filling new WAL file");
 

diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
index 7aa50a5d2e578ee1ff3b4173896e93bbd8000159..452ab88cafadf9eee2407304710fd52820403fde 100644 (file)
--- a/src/backend/storage/file/fd.c
+++ b/src/backend/storage/file/fd.c
@@ -800,7 +800,10 @@ durable_rename_excl(const char *oldfile, const char *newfile, int elevel)
        ereport(elevel,
                (errcode_for_file_access(),
                 errmsg("could not link file \"%s\" to \"%s\": %m",
-                       oldfile, newfile)));
+                       oldfile, newfile),
+                (AmCheckpointerProcess() ?
+                 errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :
+                 0)));
        return -1;
    }
    unlink(oldfile);
@@ -810,7 +813,10 @@ durable_rename_excl(const char *oldfile, const char *newfile, int elevel)
        ereport(elevel,
                (errcode_for_file_access(),
                 errmsg("could not rename file \"%s\" to \"%s\": %m",
-                       oldfile, newfile)));
+                       oldfile, newfile),
+                (AmCheckpointerProcess() ?
+                 errhint("This is known to fail occasionally during archive recovery, where it is harmless.") :
+                 0)));
        return -1;
    }
 #endif