Rename PQsslAttributes() to PQsslAttributeNames(), and const-ify fully.

Per discussion, the original name was a bit misleading, and
PQsslAttributeNames() seems more apropos.  It's not quite too late to
change this in 9.5, so let's change it while we can.

Also, make sure that the pointer array is const, not only the pointed-to
strings.

Minor documentation wordsmithing while at it.

Lars Kanis, slight adjustments by me

diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml
index 235a168815bb56a6155368bed0820f49c40d89fc..79047b376113374f42717074d1f610291405152b 100644 (file)
--- a/doc/src/sgml/libpq.sgml
+++ b/doc/src/sgml/libpq.sgml
@@ -1873,7 +1873,7 @@ int PQsslInUse(const PGconn *conn);
      
     
 
-    Attribute">
+    attribute">
      PQsslAttributePQsslAttribute
      
       
@@ -1947,13 +1947,13 @@ const char *PQsslAttribute(const PGconn *conn, const char *attribute_name);
      
     
 
-    
-     PQsslAttributesPQsslAttributes
+    names">
+     PQsslAttributeNamesPQsslAttributeNames
      
       
        Return an array of SSL attribute names available. The array is terminated by a NULL pointer.
 
-const char **PQsslAttributes(const PGconn *conn);
+const char * const * PQsslAttributeNames(const PGconn *conn);
 
       
      
@@ -1963,15 +1963,15 @@ const char **PQsslAttributes(const PGconn *conn);
      PQsslStructPQsslStruct
      
       
-       Return a pointer to an SSL-implementation specific object describing
+       Return a pointer to an SSL-implementation-specific object describing
        the connection.
 
 void *PQsslStruct(const PGconn *conn, const char *struct_name);
 
       
       
-       The structs available depends on the SSL implementation in use.
-       For OpenSSL, there is one struct, under the name "OpenSSL",
+       The struct(s) available depend on the SSL implementation in use.
+       For OpenSSL, there is one struct, available under the name "OpenSSL",
        and it returns a pointer to the OpenSSL SSL struct.
        To use this function, code along the following lines could be used:
 


diff --git a/doc/src/sgml/release-9.5.sgml b/doc/src/sgml/release-9.5.sgml

index 9055387832a2017d76709f93ee5328ceb6525a1b..771ad0ca6fac80d8db90b0d3bc0e351ccc3b9530 100644 (file)

--- a/doc/src/sgml/release-9.5.sgml
+++ b/doc/src/sgml/release-9.5.sgml
@@ -608,18 +608,22 @@ FIXME: Add Andres
 2015-02-03 [91fa7b4] Heikki..: Add API functions to libpq to interrogate SSL ..
 -->
        
-        Add libpq function 
-        linkend="libpq-pqsslAttribute">PQsslAttribute()
-        that returns SSL information (Heikki Linnakangas)
-       
-
-       
-        While PQgetssl()
-        can still be used to call OpenSSL
-        functions, PQsslAttribute() returns SSL
-        information in an SSL-implementation-independent way.
-        (Future versions of libpq might support other SSL
-        implementations.)
+        Add libpq functions to return SSL
+        information in an implementation-independent way (Heikki Linnakangas)
+       
+
+       
+        While PQgetssl() can
+        still be used to call OpenSSL functions, it is now
+        considered deprecated because future versions
+        of libpq might support other SSL
+        implementations.  When possible, use the new
+        functions 
+        linkend="libpq-pqsslattribute">PQsslAttribute(), 
+        linkend="libpq-pqsslattributenames">PQsslAttributeNames(),
+        and PQsslInUse()
+        to obtain SSL information in
+        an SSL-implementation-independent way.
        
       
 


diff --git a/src/interfaces/libpq/exports.txt b/src/interfaces/libpq/exports.txt

index 4a21bf1d2cfea62ac611092b4fe28fc5f84bb49e..33f80e63e5be4fe7c25a5e1f93eddd6a02888d50 100644 (file)

--- a/src/interfaces/libpq/exports.txt
+++ b/src/interfaces/libpq/exports.txt
@@ -167,5 +167,5 @@ lo_truncate64             164
 PQconninfo                165
 PQsslInUse                166
 PQsslStruct               167
-PQsslAttributes           168
+PQsslAttributeNames       168
 PQsslAttribute            169


diff --git a/src/interfaces/libpq/fe-secure-openssl.c b/src/interfaces/libpq/fe-secure-openssl.c

index 4b2a324634bbefc42941772bfcec625f78b80c58..45ad7321bbed4ecdfb47384eca8e24ea66308374 100644 (file)

--- a/src/interfaces/libpq/fe-secure-openssl.c
+++ b/src/interfaces/libpq/fe-secure-openssl.c
@@ -1532,10 +1532,10 @@ PQsslStruct(PGconn *conn, const char *struct_name)
    return NULL;
 }
 
-const char **
-PQsslAttributes(PGconn *conn)
+const char *const *
+PQsslAttributeNames(PGconn *conn)
 {
-   static const char *result[] = {
+   static const char *const result[] = {
        "library",
        "key_bits",
        "cipher",


diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c

index db91e52ee90fcc9acb522fd366e22784df2b8412..aa5af7340fe4297ba5623b4aceffdabe74edc482 100644 (file)

--- a/src/interfaces/libpq/fe-secure.c
+++ b/src/interfaces/libpq/fe-secure.c
@@ -408,10 +408,10 @@ PQsslAttribute(PGconn *conn, const char *attribute_name)
    return NULL;
 }
 
-const char **
-PQsslAttributes(PGconn *conn)
+const char *const *
+PQsslAttributeNames(PGconn *conn)
 {
-   static const char *result[] = {NULL};
+   static const char *const result[] = {NULL};
 
    return result;
 }


diff --git a/src/interfaces/libpq/libpq-fe.h b/src/interfaces/libpq/libpq-fe.h

index a73eae2087a26c4876308e88b61bb18ab26f0b96..bcd14ac1326d8d171ac6f104b0151b0185639aef 100644 (file)

--- a/src/interfaces/libpq/libpq-fe.h
+++ b/src/interfaces/libpq/libpq-fe.h
@@ -322,7 +322,7 @@ extern int  PQsetClientEncoding(PGconn *conn, const char *encoding);
 extern int PQsslInUse(PGconn *conn);
 extern void *PQsslStruct(PGconn *conn, const char *struct_name);
 extern const char *PQsslAttribute(PGconn *conn, const char *attribute_name);
-extern const char **PQsslAttributes(PGconn *conn);
+extern const char *const * PQsslAttributeNames(PGconn *conn);
 
 /* Get the OpenSSL structure associated with a connection. Returns NULL for
  * unencrypted connections or if any other TLS library is in use. */




This is the main PostgreSQL git repository.
RSS
Atom



window.onload = function () {
	var tz_cookie = { name: 'gitweb_tz', expires: 14, path: '/' };
	onloadTZSetup('local', tz_cookie, 'datetime');
};

diff --git a/doc/src/sgml/release-9.5.sgml b/doc/src/sgml/release-9.5.sgml
index 9055387832a2017d76709f93ee5328ceb6525a1b..771ad0ca6fac80d8db90b0d3bc0e351ccc3b9530 100644 (file)
--- a/doc/src/sgml/release-9.5.sgml
+++ b/doc/src/sgml/release-9.5.sgml
@@ -608,18 +608,22 @@ FIXME: Add Andres
 2015-02-03 [91fa7b4] Heikki..: Add API functions to libpq to interrogate SSL ..
 -->
        
-        Add libpq function 
-        linkend="libpq-pqsslAttribute">PQsslAttribute()
-        that returns SSL information (Heikki Linnakangas)
-       
-
-       
-        While PQgetssl()
-        can still be used to call OpenSSL
-        functions, PQsslAttribute() returns SSL
-        information in an SSL-implementation-independent way.
-        (Future versions of libpq might support other SSL
-        implementations.)
+        Add libpq functions to return SSL
+        information in an implementation-independent way (Heikki Linnakangas)
+       
+
+       
+        While PQgetssl() can
+        still be used to call OpenSSL functions, it is now
+        considered deprecated because future versions
+        of libpq might support other SSL
+        implementations.  When possible, use the new
+        functions 
+        linkend="libpq-pqsslattribute">PQsslAttribute(), 
+        linkend="libpq-pqsslattributenames">PQsslAttributeNames(),
+        and PQsslInUse()
+        to obtain SSL information in
+        an SSL-implementation-independent way.
        
       
 


diff --git a/src/interfaces/libpq/exports.txt b/src/interfaces/libpq/exports.txt

index 4a21bf1d2cfea62ac611092b4fe28fc5f84bb49e..33f80e63e5be4fe7c25a5e1f93eddd6a02888d50 100644 (file)

--- a/src/interfaces/libpq/exports.txt
+++ b/src/interfaces/libpq/exports.txt
@@ -167,5 +167,5 @@ lo_truncate64             164
 PQconninfo                165
 PQsslInUse                166
 PQsslStruct               167
-PQsslAttributes           168
+PQsslAttributeNames       168
 PQsslAttribute            169


diff --git a/src/interfaces/libpq/fe-secure-openssl.c b/src/interfaces/libpq/fe-secure-openssl.c

index 4b2a324634bbefc42941772bfcec625f78b80c58..45ad7321bbed4ecdfb47384eca8e24ea66308374 100644 (file)

--- a/src/interfaces/libpq/fe-secure-openssl.c
+++ b/src/interfaces/libpq/fe-secure-openssl.c
@@ -1532,10 +1532,10 @@ PQsslStruct(PGconn *conn, const char *struct_name)
    return NULL;
 }
 
-const char **
-PQsslAttributes(PGconn *conn)
+const char *const *
+PQsslAttributeNames(PGconn *conn)
 {
-   static const char *result[] = {
+   static const char *const result[] = {
        "library",
        "key_bits",
        "cipher",


diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c

index db91e52ee90fcc9acb522fd366e22784df2b8412..aa5af7340fe4297ba5623b4aceffdabe74edc482 100644 (file)

--- a/src/interfaces/libpq/fe-secure.c
+++ b/src/interfaces/libpq/fe-secure.c
@@ -408,10 +408,10 @@ PQsslAttribute(PGconn *conn, const char *attribute_name)
    return NULL;
 }
 
-const char **
-PQsslAttributes(PGconn *conn)
+const char *const *
+PQsslAttributeNames(PGconn *conn)
 {
-   static const char *result[] = {NULL};
+   static const char *const result[] = {NULL};
 
    return result;
 }


diff --git a/src/interfaces/libpq/libpq-fe.h b/src/interfaces/libpq/libpq-fe.h

index a73eae2087a26c4876308e88b61bb18ab26f0b96..bcd14ac1326d8d171ac6f104b0151b0185639aef 100644 (file)

--- a/src/interfaces/libpq/libpq-fe.h
+++ b/src/interfaces/libpq/libpq-fe.h
@@ -322,7 +322,7 @@ extern int  PQsetClientEncoding(PGconn *conn, const char *encoding);
 extern int PQsslInUse(PGconn *conn);
 extern void *PQsslStruct(PGconn *conn, const char *struct_name);
 extern const char *PQsslAttribute(PGconn *conn, const char *attribute_name);
-extern const char **PQsslAttributes(PGconn *conn);
+extern const char *const * PQsslAttributeNames(PGconn *conn);
 
 /* Get the OpenSSL structure associated with a connection. Returns NULL for
  * unencrypted connections or if any other TLS library is in use. */




This is the main PostgreSQL git repository.
RSS
Atom

diff --git a/src/interfaces/libpq/exports.txt b/src/interfaces/libpq/exports.txt
index 4a21bf1d2cfea62ac611092b4fe28fc5f84bb49e..33f80e63e5be4fe7c25a5e1f93eddd6a02888d50 100644 (file)
--- a/src/interfaces/libpq/exports.txt
+++ b/src/interfaces/libpq/exports.txt
@@ -167,5 +167,5 @@ lo_truncate64             164
 PQconninfo                165
 PQsslInUse                166
 PQsslStruct               167
-PQsslAttributes           168
+PQsslAttributeNames       168
 PQsslAttribute            169

diff --git a/src/interfaces/libpq/fe-secure-openssl.c b/src/interfaces/libpq/fe-secure-openssl.c
index 4b2a324634bbefc42941772bfcec625f78b80c58..45ad7321bbed4ecdfb47384eca8e24ea66308374 100644 (file)
--- a/src/interfaces/libpq/fe-secure-openssl.c
+++ b/src/interfaces/libpq/fe-secure-openssl.c
@@ -1532,10 +1532,10 @@ PQsslStruct(PGconn *conn, const char *struct_name)
    return NULL;
 }
 
-const char **
-PQsslAttributes(PGconn *conn)
+const char *const *
+PQsslAttributeNames(PGconn *conn)
 {
-   static const char *result[] = {
+   static const char *const result[] = {
        "library",
        "key_bits",
        "cipher",

diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
index db91e52ee90fcc9acb522fd366e22784df2b8412..aa5af7340fe4297ba5623b4aceffdabe74edc482 100644 (file)
--- a/src/interfaces/libpq/fe-secure.c
+++ b/src/interfaces/libpq/fe-secure.c
@@ -408,10 +408,10 @@ PQsslAttribute(PGconn *conn, const char *attribute_name)
    return NULL;
 }
 
-const char **
-PQsslAttributes(PGconn *conn)
+const char *const *
+PQsslAttributeNames(PGconn *conn)
 {
-   static const char *result[] = {NULL};
+   static const char *const result[] = {NULL};
 
    return result;
 }

diff --git a/src/interfaces/libpq/libpq-fe.h b/src/interfaces/libpq/libpq-fe.h
index a73eae2087a26c4876308e88b61bb18ab26f0b96..bcd14ac1326d8d171ac6f104b0151b0185639aef 100644 (file)
--- a/src/interfaces/libpq/libpq-fe.h
+++ b/src/interfaces/libpq/libpq-fe.h
@@ -322,7 +322,7 @@ extern int  PQsetClientEncoding(PGconn *conn, const char *encoding);
 extern int PQsslInUse(PGconn *conn);
 extern void *PQsslStruct(PGconn *conn, const char *struct_name);
 extern const char *PQsslAttribute(PGconn *conn, const char *attribute_name);
-extern const char **PQsslAttributes(PGconn *conn);
+extern const char *const * PQsslAttributeNames(PGconn *conn);
 
 /* Get the OpenSSL structure associated with a connection. Returns NULL for
  * unencrypted connections or if any other TLS library is in use. */