doc: Fix description of replication command CREATE_REPLICATION_SLOT

The output plugin name is a mandatory option when creating a logical
slot, but the grammar documented was not described as such.  While on
it, fix two comments in repl_gram.y to show that TEMPORARY is an
optional grammar choice.

Author: Ayaki Tachikake
Discussion: https://postgr.es/m/OSAPR01MB2852607B2329FFA27834105AF1229@OSAPR01MB2852.jpnprd01.prod.outlook.com
Backpatch-through: 15

diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
index 1a70685021ddceab792b6e41d2922458c20c6832..27c55a7c8120c8b212aa5a31e13ca38c1a3f4fd7 100644 (file)
--- a/doc/src/sgml/protocol.sgml
+++ b/doc/src/sgml/protocol.sgml
@@ -1987,7 +1987,7 @@ psql "dbname=postgres replication=database" -c "IDENTIFY_SYSTEM;"
     
 
     
-     CREATE_REPLICATION_SLOT slot_name [ TEMPORARY ] { PHYSICAL | LOGICAL } [ ( option [, ...] ) ]
+     CREATE_REPLICATION_SLOT slot_name [ TEMPORARY ] { PHYSICAL | LOGICAL output_plugin } [ ( option [, ...] ) ]
       CREATE_REPLICATION_SLOT
      
      

diff --git a/src/backend/replication/repl_gram.y b/src/backend/replication/repl_gram.y
index 4cf087e602e182a50175259b02f0d61d7f353448..ea6b8c0ade65044d2a02d9ebce91aa545050667e 100644 (file)
--- a/src/backend/replication/repl_gram.y
+++ b/src/backend/replication/repl_gram.y
@@ -174,7 +174,7 @@ base_backup:
            ;
 
 create_replication_slot:
-           /* CREATE_REPLICATION_SLOT slot TEMPORARY PHYSICAL [options] */
+           /* CREATE_REPLICATION_SLOT slot [TEMPORARY] PHYSICAL [options] */
            K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_PHYSICAL create_slot_options
                {
                    CreateReplicationSlotCmd *cmd;
@@ -185,7 +185,7 @@ create_replication_slot:
                    cmd->options = $5;
                    $$ = (Node *) cmd;
                }
-           /* CREATE_REPLICATION_SLOT slot TEMPORARY LOGICAL plugin [options] */
+           /* CREATE_REPLICATION_SLOT slot [TEMPORARY] LOGICAL plugin [options] */
            | K_CREATE_REPLICATION_SLOT IDENT opt_temporary K_LOGICAL IDENT create_slot_options
                {
                    CreateReplicationSlotCmd *cmd;