Allow HotStandbyActiveInReplay() to be called in single user mode.

HotStandbyActiveInReplay, introduced in 061b079f, only allowed WAL
replay to happen in the startup process, missing the single user case.

This buglet is fairly harmless as it only causes problems when single
user mode in an assertion enabled build is used to replay a btree vacuum
record.

Backpatch to 9.2. 061b079f was backpatched further, but the assertion
was not.

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index b974b3d438a03a03522f06cd8f56197bdcae9f21..9d160daa6cea80a1a8b4e71ac1a1fc00fb07658f 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -6442,7 +6442,7 @@ HotStandbyActive(void)
 bool
 HotStandbyActiveInReplay(void)
 {
-   Assert(AmStartupProcess());
+   Assert(AmStartupProcess() || !IsPostmasterEnvironment);
    return LocalHotStandbyActive;
 }