Don't call fwrite() with len == 0 when writing out relcache init file.

Noticed via -fsanitize=undefined.

Backpatch to all branches, for the same reasons as 46ab07ffda9.

Discussion: https://postgr.es/m/20220323173537[email protected]
Backpatch: 10-

diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 7976a0d66d4d8bade595fc490eaba20d7d9d936f..54de07218153c311a4bab0c0851f4eedbd291453 100644 (file)
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -6365,7 +6365,7 @@ write_item(const void *data, Size len, FILE *fp)
 {
    if (fwrite(&len, 1, sizeof(len), fp) != sizeof(len))
        elog(FATAL, "could not write init file");
-   if (fwrite(data, 1, len, fp) != len)
+   if (len > 0 && fwrite(data, 1, len, fp) != len)
        elog(FATAL, "could not write init file");
 }