Remove incorrect function import from pgindent
authorDaniel Gustafsson
Wed, 9 Oct 2024 07:34:34 +0000 (09:34 +0200)
committerDaniel Gustafsson
Wed, 9 Oct 2024 07:34:34 +0000 (09:34 +0200)
Commit 149ac7d4559 which re-implemented pgindent in Perl explicitly
imported the devnull function from File::Spec, but the module does
not export anything.  In recent versions of Perl calling a missing
import function cause a warning, which combined with warnings being
fatal cause pgindent to error out.

Backpatch to all supported versions.

Author: Erik Wienhold 
Reviewed-by: Andrew Dunstan
Reviewed-by: Daniel Gustafsson
Discusson: https://postgr.es/m/2372cd74-11b0-46f9-b28e-8f9627215d19@ewie.name
Backpatch-through: v12

src/tools/pgindent/pgindent

index 004b4b2a4a7bc61c4300658e43cd6986a0144e6d..eb3c882c75af5bfab1fc3b4fd33bdf3340aa18c9 100755 (executable)
@@ -5,7 +5,7 @@ use warnings;
 
 use Cwd qw(abs_path getcwd);
 use File::Find;
-use File::Spec qw(devnull);
+use File::Spec;
 use File::Temp;
 use IO::Handle;
 use Getopt::Long;