Remove dead code in pg_dump.

Coverity quite reasonably complained that this check for fout==NULL
occurred after we'd already dereferenced fout.  However, the check
is just dead code since there is no code path by which CreateArchive
can return a null pointer.  Errors such as can't-open-that-file are
reported down inside CreateArchive, and control doesn't return.
So let's silence the warning by removing the dead code, rather than
continuing to pretend it does something.

Coverity didn't complain about this before 5b5fea2a1, so back-patch
to 9.5 like that patch.

diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
index 9585c58c65c1b1f5fd7eddcb54a1a7323ade0915..020a982712cdb9d64ffcb38329c787cbe18669ce 100644 (file)
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -611,9 +611,6 @@ main(int argc, char **argv)
    /* Register the cleanup hook */
    on_exit_close_archive(fout);
 
-   if (fout == NULL)
-       exit_horribly(NULL, "could not open output file \"%s\" for writing\n", filename);
-
    /* Let the archiver know how noisy to be */
    fout->verbose = g_verbose;