Review wording on tablespaces w.r.t. partitioned tables

Remove a redundant comment, and document pg_class.reltablespace properly
in catalogs.sgml.

After commits a36c84c3e4a9, 87259588d0ab and others.

Backpatch to 12.

Discussion: https://postgr.es/m/202403191013[email protected]

diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index 7be2d3172958f138e77bb4e308cfbd9485fa5308..9052981d3003742eba197382cd1288482cc62b73 100644 (file)
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -1970,9 +1970,12 @@ SCRAM-SHA-256$<iteration count>:&l
        (references pg_tablespace.oid)
       
       
-       The tablespace in which this relation is stored.  If zero,
-       the database's default tablespace is implied.  (Not meaningful
-       if the relation has no on-disk file.)
+       The tablespace in which this relation is stored.
+       If zero, the database's default tablespace is implied.
+       Not meaningful if the relation has no on-disk file,
+       except for partitioned tables, where this is the tablespace
+       in which partitions will be created when one is not
+       specified in the creation command.
       
      
 

diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
index 1dff4c3529bbf7f66aa693918fe10daf11d40c53..b55eec11579113b84fc49219cd0672fae64a12a9 100644 (file)
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -755,10 +755,6 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid ownerId,
    }
    else if (stmt->partbound)
    {
-       /*
-        * For partitions, when no other tablespace is specified, we default
-        * the tablespace to the parent partitioned table's.
-        */
        Assert(list_length(inheritOids) == 1);
        tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));
    }