Remove configure probe for netinet/tcp.h.

 is in SUSv3 and all targeted Unix systems have it.
For Windows, we can provide a stub include file, to avoid some #ifdef
noise.

Discussion: https://postgr.es/m/CA+hUKGKErNfhmvb_H0UprEmp4LPzGN06yR2_0tYikjzB-2ECMw@mail.gmail.com

diff --git a/configure b/configure
index 6f220b9eb982aa34ff69869616d40484881000f3..b7fd6c5f4ea1002088ebf231e5c3053757a452c4 100755 (executable)
--- a/configure
+++ b/configure
@@ -13761,7 +13761,7 @@ $as_echo "#define HAVE_STDBOOL_H 1" >>confdefs.h
 fi
 
 
-for ac_header in atomic.h copyfile.h execinfo.h getopt.h ifaddrs.h langinfo.h mbarrier.h netinet/tcp.h sys/epoll.h sys/event.h sys/personality.h sys/prctl.h sys/procctl.h sys/signalfd.h sys/ucred.h termios.h ucred.h
+for ac_header in atomic.h copyfile.h execinfo.h getopt.h ifaddrs.h langinfo.h mbarrier.h sys/epoll.h sys/event.h sys/personality.h sys/prctl.h sys/procctl.h sys/signalfd.h sys/ucred.h termios.h ucred.h
 do :
   as_ac_Header=`$as_echo "ac_cv_header_$ac_header" | $as_tr_sh`
 ac_fn_c_check_header_mongrel "$LINENO" "$ac_header" "$as_ac_Header" "$ac_includes_default"

diff --git a/configure.ac b/configure.ac
index 48d3e882b3edb6267c091bb2a34d78a0a026f44a..e5740f4fb5554c02a601640bf4b2d6359e0ba301 100644 (file)
--- a/configure.ac
+++ b/configure.ac
@@ -1450,7 +1450,6 @@ AC_CHECK_HEADERS(m4_normalize([
    ifaddrs.h
    langinfo.h
    mbarrier.h
-   netinet/tcp.h
    sys/epoll.h
    sys/event.h
    sys/personality.h

diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure-openssl.c
index 9cec6866a39ec3ae2fdbc4e16ef953041b09d81d..55d4b29f7e10ba4286bcda6f316f558329cba8a4 100644 (file)
--- a/src/backend/libpq/be-secure-openssl.c
+++ b/src/backend/libpq/be-secure-openssl.c
@@ -24,10 +24,8 @@
 #include 
 #include 
 #include 
-#ifdef HAVE_NETINET_TCP_H
 #include 
 #include 
-#endif
 
 #include "libpq/libpq.h"
 #include "miscadmin.h"

diff --git a/src/backend/libpq/be-secure.c b/src/backend/libpq/be-secure.c
index a05f67afb5e79c71e6daefbdb34563f892f11896..e3e54713e8136951a040ae789f4c7f95ed756c41 100644 (file)
--- a/src/backend/libpq/be-secure.c
+++ b/src/backend/libpq/be-secure.c
@@ -24,10 +24,8 @@
 #include 
 #include 
 #include 
-#ifdef HAVE_NETINET_TCP_H
 #include 
 #include 
-#endif
 
 #include "libpq/libpq.h"
 #include "miscadmin.h"

diff --git a/src/backend/libpq/ifaddr.c b/src/backend/libpq/ifaddr.c
index 73a8707324f36aae714c1fba4fefdd5c432b732e..de35fbba4555cd9a77fdde45e6f9ed1944c107e3 100644 (file)
--- a/src/backend/libpq/ifaddr.c
+++ b/src/backend/libpq/ifaddr.c
@@ -24,9 +24,7 @@
 #include 
 #include 
 #include 
-#ifdef HAVE_NETINET_TCP_H
 #include 
-#endif
 #include 
 
 #include "libpq/ifaddr.h"

diff --git a/src/backend/libpq/pqcomm.c b/src/backend/libpq/pqcomm.c
index 3ec4328613b95cfae62847db440f8fca4c948cb1..5dd92c9f668fc6354f9c9ef3402742244d93ae00 100644 (file)
--- a/src/backend/libpq/pqcomm.c
+++ b/src/backend/libpq/pqcomm.c
@@ -67,9 +67,7 @@
 #include 
 #include 
 #include 
-#ifdef HAVE_NETINET_TCP_H
 #include 
-#endif
 #include 
 #ifdef _MSC_VER                    /* mstcpip.h is missing on mingw */
 #include 

diff --git a/src/common/ip.c b/src/common/ip.c
index dd9193feb1bcee554f1ca37f28cd533a6361d43a..0149d07ae7ca843522bd462b48f51982064e8dab 100644 (file)
--- a/src/common/ip.c
+++ b/src/common/ip.c
@@ -28,9 +28,7 @@
 #include 
 #include 
 #include 
-#ifdef HAVE_NETINET_TCP_H
 #include 
-#endif
 #include 
 #include 
 

diff --git a/src/include/libpq/libpq-be.h b/src/include/libpq/libpq-be.h
index fa2fd030095b5388f7f779c4e6f3d57bb525c0b4..32d3a4b08532b5996f8abf6b3735b9e707cda2e8 100644 (file)
--- a/src/include/libpq/libpq-be.h
+++ b/src/include/libpq/libpq-be.h
@@ -23,9 +23,7 @@
 #include 
 #include 
 #endif
-#ifdef HAVE_NETINET_TCP_H
 #include 
-#endif
 
 #ifdef ENABLE_GSS
 #if defined(HAVE_GSSAPI_H)

diff --git a/src/include/pg_config.h.in b/src/include/pg_config.h.in
index de8daa2f1140cc6370c20dce5fca87c9394c9a02..b8fe2201f49b7a355f35674a3c4e60e19d2d9a70 100644 (file)
--- a/src/include/pg_config.h.in
+++ b/src/include/pg_config.h.in
@@ -322,9 +322,6 @@
 /* Define to 1 if you have the `mkdtemp' function. */
 #undef HAVE_MKDTEMP
 
-/* Define to 1 if you have the  header file. */
-#undef HAVE_NETINET_TCP_H
-
 /* Define to 1 if you have the `OPENSSL_init_ssl' function. */
 #undef HAVE_OPENSSL_INIT_SSL
 

diff --git a/src/include/port/win32/netinet/tcp.h b/src/include/port/win32/netinet/tcp.h
new file mode 100644 (file)
index 0000000..1d377b6
--- /dev/null
+++ b/src/include/port/win32/netinet/tcp.h
@@ -0,0 +1,7 @@
+/* src/include/port/win32/netinet/tcp.h */
+#ifndef WIN32_NETINET_TCP_H
+#define WIN32_NETINET_TCP_H
+
+#include 
+
+#endif

diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 1e057db336a6cdbd4632e0a231a94fbd186d307d..ec6c17cd0bf7cc194d7b004f64dad8be9b68dfc6 100644 (file)
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -51,10 +51,8 @@
 #include 
 #include 
 #include 
-#ifdef HAVE_NETINET_TCP_H
 #include 
 #endif
-#endif
 
 #ifdef ENABLE_THREAD_SAFETY
 #ifdef WIN32

diff --git a/src/interfaces/libpq/fe-protocol3.c b/src/interfaces/libpq/fe-protocol3.c
index f267dfd33c5373cc2df07bc67a8a308c905710d1..bbfb55542df8d1395eb2f919d2bca14ff61d8b53 100644 (file)
--- a/src/interfaces/libpq/fe-protocol3.c
+++ b/src/interfaces/libpq/fe-protocol3.c
@@ -21,10 +21,8 @@
 #include "win32.h"
 #else
 #include 
-#ifdef HAVE_NETINET_TCP_H
 #include 
 #endif
-#endif
 
 #include "libpq-fe.h"
 #include "libpq-int.h"

diff --git a/src/interfaces/libpq/fe-secure-openssl.c b/src/interfaces/libpq/fe-secure-openssl.c
index 3cc75380e0296e8821b96cac0687aab39c4a9a3f..3798bb3f11c0f090a1d97e034fcaa5fc82d3ec76 100644 (file)
--- a/src/interfaces/libpq/fe-secure-openssl.c
+++ b/src/interfaces/libpq/fe-secure-openssl.c
@@ -38,9 +38,7 @@
 #include 
 #include 
 #include 
-#ifdef HAVE_NETINET_TCP_H
 #include 
-#endif
 #include 
 #endif
 

diff --git a/src/interfaces/libpq/fe-secure.c b/src/interfaces/libpq/fe-secure.c
index a1dc7b796d16943d1515257c9f780204784ae893..3df4a97f2e90e6eba9c90415da5120926d4f10ed 100644 (file)
--- a/src/interfaces/libpq/fe-secure.c
+++ b/src/interfaces/libpq/fe-secure.c
@@ -29,9 +29,7 @@
 #include 
 #include 
 #include 
-#ifdef HAVE_NETINET_TCP_H
 #include 
-#endif
 #include 
 #endif
 

diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
index 5ad275b223620120b6c172e9c6fd01ea9114935a..55b30090f6e9b504ca116afb9b5197c122496fdd 100644 (file)
--- a/src/tools/msvc/Solution.pm
+++ b/src/tools/msvc/Solution.pm
@@ -304,7 +304,6 @@ sub GenerateFiles
        HAVE_MEMORY_H               => 1,
        HAVE_MEMSET_S               => undef,
        HAVE_MKDTEMP                => undef,
-       HAVE_NETINET_TCP_H          => undef,
        HAVE_OPENSSL_INIT_SSL       => undef,
        HAVE_OSSP_UUID_H            => undef,
        HAVE_PAM_PAM_APPL_H         => undef,