PageAddItem in overwrite mode: must *NOT* check itemid' flag if
authorVadim B. Mikheev
Tue, 6 Feb 2001 06:24:00 +0000 (06:24 +0000)
committerVadim B. Mikheev
Tue, 6 Feb 2001 06:24:00 +0000 (06:24 +0000)
OffsetNumber == MaxOffsetNumber + 1 - there may be garbage there!

src/backend/storage/page/bufpage.c

index 02022f9333b42cb8358600b718898a725bd30d0d..02528a30e678a48a42f8d6c1267e355a72775e31 100644 (file)
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *   $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.35 2001/01/24 19:43:08 momjian Exp $
+ *   $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.36 2001/02/06 06:24:00 vadim Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -112,12 +112,15 @@ PageAddItem(Page page,
                elog(NOTICE, "PageAddItem: tried overwrite after maxoff");
                return InvalidOffsetNumber;
            }
-           itemId = &((PageHeader) page)->pd_linp[offsetNumber - 1];
-           if (((*itemId).lp_flags & LP_USED) ||
-               ((*itemId).lp_len != 0))
+           if (offsetNumber < limit)
            {
-               elog(NOTICE, "PageAddItem: tried overwrite of used ItemId");
-               return InvalidOffsetNumber;
+               itemId = &((PageHeader) page)->pd_linp[offsetNumber - 1];
+               if (((*itemId).lp_flags & LP_USED) ||
+                   ((*itemId).lp_len != 0))
+               {
+                   elog(NOTICE, "PageAddItem: tried overwrite of used ItemId");
+                   return InvalidOffsetNumber;
+               }
            }
        }
        else