Remove poorly worded and duplicated comment
authorSimon Riggs
Mon, 8 May 2017 07:49:28 +0000 (08:49 +0100)
committerSimon Riggs
Mon, 8 May 2017 07:49:28 +0000 (08:49 +0100)
Move line of code to avoid need for duplicated comment

Brought to attention by Masahiko Sawada

src/backend/utils/time/snapmgr.c

index 3a3a25a0c36ba5577ca53694f34202b01cec9e73..5fa665eafc4a4859e81940bd796113aa4024ba40 100644 (file)
@@ -2039,14 +2039,6 @@ SerializeSnapshot(Snapshot snapshot, char *start_address)
    serialized_snapshot.whenTaken = snapshot->whenTaken;
    serialized_snapshot.lsn = snapshot->lsn;
 
-   /*
-    * Ignore the SubXID array if it has overflowed, unless the snapshot was
-    * taken during recovey - in that case, top-level XIDs are in subxip as
-    * well, and we mustn't lose them.
-    */
-   if (serialized_snapshot.suboverflowed && !snapshot->takenDuringRecovery)
-       serialized_snapshot.subxcnt = 0;
-
    /* Copy struct to possibly-unaligned buffer */
    memcpy(start_address,
           &serialized_snapshot, sizeof(SerializedSnapshotData));
@@ -2063,6 +2055,9 @@ SerializeSnapshot(Snapshot snapshot, char *start_address)
     * snapshot taken during recovery; all the top-level XIDs are in subxip as
     * well in that case, so we mustn't lose them.
     */
+   if (serialized_snapshot.suboverflowed && !snapshot->takenDuringRecovery)
+       serialized_snapshot.subxcnt = 0;
+
    if (serialized_snapshot.subxcnt > 0)
    {
        Size        subxipoff = sizeof(SerializedSnapshotData) +