Skip to content

Commit d418d95

Browse files
authored
Misc test fixes (GoogleCloudPlatform#903)
1 parent 5d52043 commit d418d95

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

datastore/api/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ To run the tests do the following:
1717
1. **Install dependencies** via [Composer](http://getcomposer.org/doc/00-intro.md).
1818
Run `php composer.phar install` (if composer is installed locally) or `composer install`
1919
(if composer is installed globally).
20-
1. Create Datastore indexes by running `gcloud datastore create-indexes index.yaml`
20+
1. Create Datastore indexes by running `gcloud datastore indexes create index.yaml`
2121
1. Check the [Indexes](https://console.cloud.google.com/datastore/indexes) page to verify the indexes have been created.
2222
1. Run `phpunit`

logging/test/loggingTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ public function setUp()
4444
{
4545
$this->useResourceExhaustedBackoff(5);
4646
$this->catchAllExceptions = true;
47-
$this->eventuallyConsistentRetryCount = 5;
4847
}
4948

5049
public function testCreateSink()
@@ -156,7 +155,7 @@ public function testWriteAndList()
156155
'--logger' => $loggerName,
157156
]);
158157
$this->assertContains($message, $output);
159-
});
158+
}, $retries = 10);
160159
}
161160

162161
/**

monitoring/src/write_timeseries.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ function write_timeseries($projectId)
4848
]);
4949

5050
$projectName = $metrics->projectName($projectId);
51-
$filter = 'metric.type="compute.googleapis.com/instance/cpu/utilization"';
5251

5352
$endTime = new Timestamp();
5453
$endTime->setSeconds(time());

testing/run_test_suite.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ ALT_PROJECT_TESTS=(
4141
appengine/flexible/storage
4242
bigquery/api
4343
bigquery/quickstart
44+
bigtable
4445
datastore/api
4546
datastore/tutorial
46-
bigtable
4747
dialogflow
4848
dlp
4949
error_reporting

vision/src/detect_text_gcs.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ function detect_text_gcs($path)
4343
print('Bounds: ' . join(', ',$bounds) . PHP_EOL);
4444
}
4545

46+
if ($error = $response->getError()) {
47+
print('API Error: ' . $error->getMessage() . PHP_EOL);
48+
}
49+
4650
$imageAnnotator->close();
4751
}
4852
// [END vision_text_detection_gcs]

0 commit comments

Comments
 (0)