fix: proper strict arguments for cdn samples (GoogleCloudPlatform#1116)

bshaffer · web-flow · commit f5c664c62b50 · 2020-06-18T13:46:25.000-07:00
diff --git a/cdn/signUrl.php b/cdn/signUrl.php
@@ -26,7 +26,7 @@
 function base64url_decode($input)
 {
     $input .= str_repeat('=', (4 - strlen($input) % 4) % 4);
-    return base64_decode(strtr($input, '-_', '+/'));
+    return base64_decode(strtr($input, '-_', '+/'), true);
 }
 
 /**
@@ -66,7 +66,7 @@ function base64url_encode($input, $padding = true)
 function sign_url($url, $keyName, $base64UrlKey, $expirationTime)
 {
     // Decode the key
-    $decodedKey = base64url_decode($base64UrlKey, true);
+    $decodedKey = base64url_decode($base64UrlKey);
 
     // Determine which separator makes sense given a URL
     $separator = (strpos($url, '?') === false) ? '?' : '&';

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`function base64url_decode($input)`
`27`	`27`	`{`
`28`	`28`	`$input .= str_repeat('=', (4 - strlen($input) % 4) % 4);`
`29`		`- return base64_decode(strtr($input, '-_', '+/'));`
	`29`	`+ return base64_decode(strtr($input, '-_', '+/'), true);`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`/**`
`@@ -66,7 +66,7 @@ function base64url_encode($input, $padding = true)`
`66`	`66`	`function sign_url($url, $keyName, $base64UrlKey, $expirationTime)`
`67`	`67`	`{`
`68`	`68`	`// Decode the key`
`69`		`- $decodedKey = base64url_decode($base64UrlKey, true);`
	`69`	`+ $decodedKey = base64url_decode($base64UrlKey);`
`70`	`70`
`71`	`71`	`// Determine which separator makes sense given a URL`
`72`	`72`	`$separator = (strpos($url, '?') === false) ? '?' : '&';`